Page MenuHomePhabricator

Extend ExprTraversal class with acending traversal
AbandonedPublic

Authored by steveire on Jan 20 2020, 4:07 AM.

Details

Reviewers
aaron.ballman
Summary

This allows ASTContext to store only one parent map, rather than storing
an entire parent map for each traversal mode used.

This is therefore a partial revert of commit 0a717d5b (Make it possible
control matcher traversal kind with ASTContext, 2019-12-06).

Event Timeline

steveire created this revision.Jan 20 2020, 4:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2020, 4:07 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Test cases?

clang/lib/AST/ASTContext.cpp
1066

Please spell the type out instead of using auto.

1070

const auto * (same below) because the type is spelled out in the initialization.

1086

const auto * so we don't have to infer the constness (same below with P).

clang/lib/AST/ExprTraversal.cpp
278

const auto * here and elsewhere

rsmith added a subscriber: rsmith.Jan 24 2020, 1:09 PM

We're working on moving the parent map out of ASTContext and into something specific to tooling; please don't add more dependencies onto it in the AST library.

steveire abandoned this revision.Jan 26 2020, 11:15 AM