Page MenuHomePhabricator

[libomptarget] Implement smid for amdgcn
ClosedPublic

Authored by JonChesterfield on Jan 17 2020, 1:27 PM.

Details

Summary

[libomptarget] Implement smid for amdgcn

Implementation is in a new file as it uses an intrinsic with
complicated encoding that warranted substantial comments.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2020, 1:27 PM
jdoerfert accepted this revision.Jan 17 2020, 4:11 PM

LGTM, I mean it is black magic but that is to be expected. One comment below.

openmp/libomptarget/deviceRTLs/amdgcn/src/amdgcn_smid.hip
57

I would prefer these to be ENUMs with documentation instead of defines. I would also opt for // comments instead.

Other than that I just believe you this does something useful.

This revision is now accepted and ready to land.Jan 17 2020, 4:11 PM
  • address review comments

Change comment style and defines to enum values, thanks. Also extended the documentation a little. The more clues we can give our future selves here the better.

This revision was automatically updated to reflect the committed changes.