[libomptarget] Implement smid for amdgcn
Implementation is in a new file as it uses an intrinsic with
complicated encoding that warranted substantial comments.
Differential D72956
[libomptarget] Implement smid for amdgcn JonChesterfield on Jan 17 2020, 1:27 PM. Authored by
Details [libomptarget] Implement smid for amdgcn Implementation is in a new file as it uses an intrinsic with
Diff Detail
Event TimelineComment Actions LGTM, I mean it is black magic but that is to be expected. One comment below.
Comment Actions Change comment style and defines to enum values, thanks. Also extended the documentation a little. The more clues we can give our future selves here the better. |
I would prefer these to be ENUMs with documentation instead of defines. I would also opt for // comments instead.
Other than that I just believe you this does something useful.