Page MenuHomePhabricator

TableGen/GlobalISel: Don't take reference to temporary values
ClosedPublic

Authored by arsenm on Jan 14 2020, 11:11 AM.

Details

Summary

These return temporary Optional<> values which are immediately
destroyed. I'm not sure why no sanitizers seem to have caught this,
but I encountered crashes on these in a future patch.

Diff Detail

Event Timeline

arsenm created this revision.Jan 14 2020, 11:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2020, 11:11 AM
This revision is now accepted and ready to land.Jan 14 2020, 1:35 PM