Page MenuHomePhabricator

[ThinLTO/WPD] Remove an overly-aggressive assert
ClosedPublic

Authored by tejohnson on Jan 13 2020, 2:09 PM.

Details

Summary

An assert added to the index-based WPD was trying to verify that we only
have multiple vtables for a given guid when they are all non-external
linkage. This is too conservative because we may have multiple external
vtable with the same guid when they are in comdat. Remove the assert,
as we don't have comdat information in the index, the linker should
issue an error in this case.

See discussion on D71040 for more information.

Diff Detail

Event Timeline

tejohnson created this revision.Jan 13 2020, 2:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2020, 2:09 PM
This revision is now accepted and ready to land.Jan 14 2020, 10:54 AM
This revision was automatically updated to reflect the committed changes.