Page MenuHomePhabricator

[clangd] Improve ObjC property handling in SelectionTree.
ClosedPublic

Authored by sammccall on Jan 13 2020, 10:54 AM.

Diff Detail

Event Timeline

sammccall created this revision.Jan 13 2020, 10:54 AM
dgoldman requested changes to this revision.Jan 13 2020, 11:02 AM
dgoldman added inline comments.
clang-tools-extra/clangd/unittests/SelectionTests.cpp
347

Please add a test for the case mentioned in https://github.com/clangd/clangd/issues/253 as well (for implicit property refs) even though it should also be a ObjCPropertyRefExpr

This revision now requires changes to proceed.Jan 13 2020, 11:02 AM

Unit tests: pass. 61796 tests passed, 0 failed and 781 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

sammccall updated this revision to Diff 240377.Sat, Jan 25, 6:53 AM

more tests

sammccall marked an inline comment as done.Sat, Jan 25, 6:53 AM

Unit tests: pass. 62195 tests passed, 0 failed and 815 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

dgoldman accepted this revision.Sat, Jan 25, 8:58 AM
This revision is now accepted and ready to land.Sat, Jan 25, 8:58 AM
This revision was automatically updated to reflect the committed changes.