Page MenuHomePhabricator

dgoldman (David Goldman)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 26 2018, 1:58 PM (65 w, 4 d)

Recent Activity

Yesterday

dgoldman committed rG60249c2c3b9e: [clangd] Only re-open files if their flags changed (authored by dgoldman).
[clangd] Only re-open files if their flags changed
Mon, Jan 27, 8:03 AM
dgoldman closed D72647: [clangd] Only re-open files if their flags changed.
Mon, Jan 27, 8:02 AM · Restricted Project

Sat, Jan 25

dgoldman accepted D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences().
Sat, Jan 25, 9:04 AM · Restricted Project
dgoldman accepted D72634: [clangd] Improve ObjC property handling in SelectionTree..
Sat, Jan 25, 8:59 AM · Restricted Project

Thu, Jan 23

dgoldman updated the diff for D72647: [clangd] Only re-open files if their flags changed.
  • Swap to stringset and simpler way of tracking modified files
Thu, Jan 23, 8:10 AM · Restricted Project
dgoldman added a comment to D72647: [clangd] Only re-open files if their flags changed.

Let's make the minimal change here and land this.

Thu, Jan 23, 8:10 AM · Restricted Project

Tue, Jan 14

dgoldman added inline comments to D72647: [clangd] Only re-open files if their flags changed.
Tue, Jan 14, 7:52 AM · Restricted Project

Mon, Jan 13

dgoldman updated the diff for D72647: [clangd] Only re-open files if their flags changed.
  • Fix broken did-change-configuration test
Mon, Jan 13, 3:08 PM · Restricted Project
dgoldman created D72647: [clangd] Only re-open files if their flags changed.
Mon, Jan 13, 2:02 PM · Restricted Project
dgoldman requested changes to D72634: [clangd] Improve ObjC property handling in SelectionTree..
Mon, Jan 13, 11:03 AM · Restricted Project

Fri, Jan 10

dgoldman accepted D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties..

LGMT, thanks for fixing

Fri, Jan 10, 8:39 AM · Restricted Project
dgoldman requested changes to D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences().
Fri, Jan 10, 8:39 AM · Restricted Project

Thu, Jan 9

dgoldman committed rGea9888b8f6f2: [clangd] Respect `--sysroot` argument if it is set (authored by dgoldman).
[clangd] Respect `--sysroot` argument if it is set
Thu, Jan 9, 8:12 AM
dgoldman closed D72415: [clangd] Respect `--sysroot` argument if it is set.
Thu, Jan 9, 8:12 AM · Restricted Project

Wed, Jan 8

dgoldman created D72415: [clangd] Respect `--sysroot` argument if it is set.
Wed, Jan 8, 2:04 PM · Restricted Project

Nov 4 2019

dgoldman added a comment to D68590: [clangd] Improve hover support for Objective-C.

We'll also want to do something similar for DocumentSymbols, see here, which will lead to Objective-C categories showing up as either (anonymous) or <category name>

Nov 4 2019, 2:08 PM · Restricted Project
dgoldman added a comment to D68590: [clangd] Improve hover support for Objective-C.

Will revisit this once more critical fixes are in (crash fixes), I'm still not sure where this sort of stuff should belong

Nov 4 2019, 12:13 PM · Restricted Project

Oct 25 2019

dgoldman committed rG7a2b704bf0cf: [Sema][Typo Correction] Fix another infinite loop on ambiguity (authored by dgoldman).
[Sema][Typo Correction] Fix another infinite loop on ambiguity
Oct 25 2019, 10:25 AM
dgoldman closed D69060: [Sema][Typo Correction] Fix another infinite loop on ambiguity.
Oct 25 2019, 10:25 AM · Restricted Project

Oct 21 2019

dgoldman committed rGe5ecba4f53e7: [clang-fuzzer] Add new fuzzer target for Objective-C (authored by dgoldman).
[clang-fuzzer] Add new fuzzer target for Objective-C
Oct 21 2019, 1:46 PM
dgoldman closed D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.
Oct 21 2019, 1:46 PM · Restricted Project
dgoldman committed rL375453: [clang-fuzzer] Add new fuzzer target for Objective-C.
[clang-fuzzer] Add new fuzzer target for Objective-C
Oct 21 2019, 1:46 PM
dgoldman committed rL375451: Request commit access for dgoldman.
Request commit access for dgoldman
Oct 21 2019, 1:36 PM
dgoldman added inline comments to D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.
Oct 21 2019, 9:11 AM · Restricted Project
dgoldman updated the diff for D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.
  • Swap to reinterpret_cast
Oct 21 2019, 9:11 AM · Restricted Project
dgoldman updated the diff for D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.
  • Refactor to use handle-cxx
Oct 21 2019, 9:01 AM · Restricted Project

Oct 18 2019

dgoldman added reviewers for D69171: [clang-fuzzer] Add new fuzzer target for Objective-C: morehouse, kcc.
Oct 18 2019, 11:44 AM · Restricted Project
dgoldman added a comment to D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.

Not sure who is best to review, feel free to add someone else instead.

Oct 18 2019, 11:44 AM · Restricted Project
dgoldman added a comment to D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.

Rather than adding a new fuzzer binary, can we make the language an option?
The whole implementation seems almost identical down to handleobjc/handlecxx...

Oct 18 2019, 10:11 AM · Restricted Project
dgoldman added inline comments to D56924: Special case ObjCPropertyDecl for printing.
Oct 18 2019, 9:06 AM · Restricted Project
dgoldman created D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.
Oct 18 2019, 8:20 AM · Restricted Project

Oct 16 2019

dgoldman created D69060: [Sema][Typo Correction] Fix another infinite loop on ambiguity.
Oct 16 2019, 11:15 AM · Restricted Project

Oct 7 2019

dgoldman created D68590: [clangd] Improve hover support for Objective-C.
Oct 7 2019, 2:05 PM · Restricted Project

Sep 30 2019

dgoldman added a comment to D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.

For the record, there was another change regarding the delayed typos in clang::Sema::~Sema(): D62648 [Sema][Typo] Fix assertion failure for expressions with multiple typos.

Sep 30 2019, 9:11 AM · Restricted Project

Sep 13 2019

dgoldman committed rG6d1865042164: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks (authored by dgoldman).
[Sema][Typo Correction] Fix potential infite loop on ambiguity checks
Sep 13 2019, 7:44 AM
dgoldman committed rL371859: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks.
[Sema][Typo Correction] Fix potential infite loop on ambiguity checks
Sep 13 2019, 7:44 AM
dgoldman closed D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks.
Sep 13 2019, 7:44 AM · Restricted Project, Restricted Project
dgoldman updated the diff for D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks.
  • Fix typo in test
Sep 13 2019, 7:29 AM · Restricted Project, Restricted Project

Sep 12 2019

dgoldman updated the diff for D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks.
  • Fix method name in test
Sep 12 2019, 12:45 PM · Restricted Project, Restricted Project
dgoldman created D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks.
Sep 12 2019, 12:41 PM · Restricted Project, Restricted Project

Aug 20 2019

dgoldman committed rGfd4d77707ff8: [Sema][Typo] Fix assertion failure for expressions with multiple typos (authored by dgoldman).
[Sema][Typo] Fix assertion failure for expressions with multiple typos
Aug 20 2019, 12:03 PM
dgoldman committed rL369427: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
[Sema][Typo] Fix assertion failure for expressions with multiple typos
Aug 20 2019, 12:03 PM
dgoldman closed D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
Aug 20 2019, 12:03 PM · Restricted Project, Restricted Project

Aug 5 2019

dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • remove extra newline
Aug 5 2019, 12:47 PM · Restricted Project, Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.

Fix test failure via TransformTypos

Aug 5 2019, 12:47 PM · Restricted Project, Restricted Project

Jul 25 2019

dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Fix test failure: typo-correction-cxx11.cpp
Jul 25 2019, 7:58 AM · Restricted Project, Restricted Project

Jul 22 2019

dgoldman added a comment to D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.

Thanks, LGTM. Do you need someone to commit this for you?

Jul 22 2019, 3:26 PM · Restricted Project, Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Bug fixes
Jul 22 2019, 1:55 PM · Restricted Project, Restricted Project

Jul 19 2019

dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Minor fixes
Jul 19 2019, 11:02 AM · Restricted Project, Restricted Project

Jun 27 2019

dgoldman added inline comments to D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
Jun 27 2019, 8:31 AM · Restricted Project, Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Minor fixes
Jun 27 2019, 8:25 AM · Restricted Project, Restricted Project

Jun 21 2019

dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Add another test and fix up comment
Jun 21 2019, 8:54 AM · Restricted Project, Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Fix ambiguity handling and add more tests
Jun 21 2019, 8:38 AM · Restricted Project, Restricted Project

Jun 4 2019

dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Move if empty check back
Jun 4 2019, 1:33 PM · Restricted Project, Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Remove unused State variable
Jun 4 2019, 7:39 AM · Restricted Project, Restricted Project

Jun 3 2019

dgoldman added inline comments to D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
Jun 3 2019, 4:32 PM · Restricted Project, Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Fix discarded correction test
Jun 3 2019, 12:28 PM · Restricted Project, Restricted Project
dgoldman added a reviewer for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos: rsmith.
Jun 3 2019, 12:22 PM · Restricted Project, Restricted Project
dgoldman added inline comments to D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
Jun 3 2019, 12:22 PM · Restricted Project, Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Fix diagnostics for ignored TypoExprs
Jun 3 2019, 12:08 PM · Restricted Project, Restricted Project

May 30 2019

dgoldman created D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
May 30 2019, 1:14 AM · Restricted Project, Restricted Project

Apr 8 2019

dgoldman committed rGfa8185c504e9: Clean up ObjCPropertyDecl printing (authored by dgoldman).
Clean up ObjCPropertyDecl printing
Apr 8 2019, 12:52 PM
dgoldman committed rC357937: Clean up ObjCPropertyDecl printing.
Clean up ObjCPropertyDecl printing
Apr 8 2019, 12:51 PM
dgoldman committed rL357937: Clean up ObjCPropertyDecl printing.
Clean up ObjCPropertyDecl printing
Apr 8 2019, 12:51 PM
dgoldman closed D57965: Clean up ObjCPropertyDecl printing.
Apr 8 2019, 12:51 PM · Restricted Project, Restricted Project
dgoldman updated the diff for D57965: Clean up ObjCPropertyDecl printing.
  • Rebase
Apr 8 2019, 12:47 PM · Restricted Project, Restricted Project

Apr 5 2019

dgoldman committed rG4af5d748ce34: Fix error in NamedDeclPrinterTest (authored by dgoldman).
Fix error in NamedDeclPrinterTest
Apr 5 2019, 12:16 PM
dgoldman committed rL357799: Fix error in NamedDeclPrinterTest.
Fix error in NamedDeclPrinterTest
Apr 5 2019, 12:16 PM
dgoldman committed rC357799: Fix error in NamedDeclPrinterTest.
Fix error in NamedDeclPrinterTest
Apr 5 2019, 12:15 PM
dgoldman closed D60326: Fix error in NamedDeclPrinterTest.
Apr 5 2019, 12:15 PM · Restricted Project
dgoldman created D60326: Fix error in NamedDeclPrinterTest.
Apr 5 2019, 11:23 AM · Restricted Project

Apr 4 2019

dgoldman committed rG19d21854e92e: Special case ObjCPropertyDecl for printing (authored by dgoldman).
Special case ObjCPropertyDecl for printing
Apr 4 2019, 1:12 PM
dgoldman closed D56924: Special case ObjCPropertyDecl for printing.

Closed via rL357720

Apr 4 2019, 1:12 PM · Restricted Project
dgoldman committed rL357720: Special case ObjCPropertyDecl for printing.
Special case ObjCPropertyDecl for printing
Apr 4 2019, 1:11 PM
dgoldman committed rC357720: Special case ObjCPropertyDecl for printing.
Special case ObjCPropertyDecl for printing
Apr 4 2019, 1:11 PM
dgoldman updated the diff for D56924: Special case ObjCPropertyDecl for printing.

Rebase

Apr 4 2019, 1:05 PM · Restricted Project

Apr 2 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

ping

Apr 2 2019, 11:52 AM · Restricted Project

Mar 19 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

ping

Mar 19 2019, 12:11 PM · Restricted Project
dgoldman added a comment to D57965: Clean up ObjCPropertyDecl printing.

friendly ping

Mar 19 2019, 12:11 PM · Restricted Project, Restricted Project

Mar 12 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

ping

Mar 12 2019, 8:44 AM · Restricted Project

Mar 5 2019

dgoldman updated the summary of D57965: Clean up ObjCPropertyDecl printing.
Mar 5 2019, 7:35 AM · Restricted Project, Restricted Project
dgoldman added a reviewer for D57965: Clean up ObjCPropertyDecl printing: jkorous.
Mar 5 2019, 7:35 AM · Restricted Project, Restricted Project
dgoldman updated the diff for D57965: Clean up ObjCPropertyDecl printing.
  • Fix broken test by last change
Mar 5 2019, 7:29 AM · Restricted Project, Restricted Project
dgoldman updated the diff for D57965: Clean up ObjCPropertyDecl printing.
  • Add more tests and improved printing of pointers
Mar 5 2019, 7:26 AM · Restricted Project, Restricted Project

Mar 4 2019

dgoldman added a comment to D57965: Clean up ObjCPropertyDecl printing.

Hi David,
I am just wondering - while you're here would you mind adding couple more tests? It would be great to have a test for each attribute.

Also, what do you think about Ben's suggestion? I think it would be nice to be consistent with the style Objective-C documentation uses:
https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/EncapsulatingData/EncapsulatingData.html

Mar 4 2019, 1:18 PM · Restricted Project, Restricted Project
dgoldman added a reviewer for D57965: Clean up ObjCPropertyDecl printing: akyrtzi.
Mar 4 2019, 8:26 AM · Restricted Project, Restricted Project
dgoldman added a comment to D57965: Clean up ObjCPropertyDecl printing.

Friendly ping

Mar 4 2019, 8:26 AM · Restricted Project, Restricted Project

Feb 28 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

friendly ping, think this is good to go now

Feb 28 2019, 10:26 AM · Restricted Project

Feb 27 2019

dgoldman closed D58062: Support framework import/include auto-completion.

Closed via rL355008

Feb 27 2019, 9:48 AM · Restricted Project
dgoldman committed rG3e804d258198: Support framework import/include auto-completion (authored by dgoldman).
Support framework import/include auto-completion
Feb 27 2019, 9:40 AM
dgoldman committed rC355008: Support framework import/include auto-completion.
Support framework import/include auto-completion
Feb 27 2019, 9:40 AM
dgoldman committed rL355008: Support framework import/include auto-completion.
Support framework import/include auto-completion
Feb 27 2019, 9:39 AM

Feb 25 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

Please add a test that covers the '(class extension)' output as well.

Feb 25 2019, 10:25 AM · Restricted Project
dgoldman retitled D56924: Special case ObjCPropertyDecl for printing from Handle ObjCCategoryDecl class extensions for print to Special case ObjCPropertyDecl for printing.
Feb 25 2019, 10:24 AM · Restricted Project
dgoldman updated the diff for D56924: Special case ObjCPropertyDecl for printing.
  • Remove (class extension) as it's no longer needed
Feb 25 2019, 10:21 AM · Restricted Project

Feb 22 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

ping, looking to get this in to fix a clangd assertion failure

Feb 22 2019, 2:06 PM · Restricted Project

Feb 15 2019

dgoldman added a comment to D58062: Support framework import/include auto-completion.

Great, thank you! Want me to land this?

(You can certainly get your own commit access at this point if you like: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access and point at a couple of your patches)

Feb 15 2019, 9:33 AM · Restricted Project

Feb 14 2019

dgoldman added a comment to D58062: Support framework import/include auto-completion.

added test

Feb 14 2019, 1:14 PM · Restricted Project
dgoldman updated the diff for D58062: Support framework import/include auto-completion.
  • Add test and fix subfolder bug
Feb 14 2019, 1:14 PM · Restricted Project

Feb 12 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

ping

Feb 12 2019, 1:56 PM · Restricted Project