Page MenuHomePhabricator

dgoldman (David Goldman)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 26 2018, 1:58 PM (38 w, 2 d)

Recent Activity

Fri, Jul 19

dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Minor fixes
Fri, Jul 19, 11:02 AM · Restricted Project

Thu, Jun 27

dgoldman added inline comments to D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
Thu, Jun 27, 8:31 AM · Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Minor fixes
Thu, Jun 27, 8:25 AM · Restricted Project

Jun 21 2019

dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Add another test and fix up comment
Jun 21 2019, 8:54 AM · Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Fix ambiguity handling and add more tests
Jun 21 2019, 8:38 AM · Restricted Project

Jun 4 2019

dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Move if empty check back
Jun 4 2019, 1:33 PM · Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Remove unused State variable
Jun 4 2019, 7:39 AM · Restricted Project

Jun 3 2019

dgoldman added inline comments to D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
Jun 3 2019, 4:32 PM · Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Fix discarded correction test
Jun 3 2019, 12:28 PM · Restricted Project
dgoldman added a reviewer for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos: rsmith.
Jun 3 2019, 12:22 PM · Restricted Project
dgoldman added inline comments to D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
Jun 3 2019, 12:22 PM · Restricted Project
dgoldman updated the diff for D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
  • Fix diagnostics for ignored TypoExprs
Jun 3 2019, 12:08 PM · Restricted Project

May 30 2019

dgoldman created D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos.
May 30 2019, 1:14 AM · Restricted Project

Apr 8 2019

dgoldman committed rGfa8185c504e9: Clean up ObjCPropertyDecl printing (authored by dgoldman).
Clean up ObjCPropertyDecl printing
Apr 8 2019, 12:52 PM
dgoldman committed rC357937: Clean up ObjCPropertyDecl printing.
Clean up ObjCPropertyDecl printing
Apr 8 2019, 12:51 PM
dgoldman committed rL357937: Clean up ObjCPropertyDecl printing.
Clean up ObjCPropertyDecl printing
Apr 8 2019, 12:51 PM
dgoldman closed D57965: Clean up ObjCPropertyDecl printing.
Apr 8 2019, 12:51 PM · Restricted Project, Restricted Project
dgoldman updated the diff for D57965: Clean up ObjCPropertyDecl printing.
  • Rebase
Apr 8 2019, 12:47 PM · Restricted Project, Restricted Project

Apr 5 2019

dgoldman committed rG4af5d748ce34: Fix error in NamedDeclPrinterTest (authored by dgoldman).
Fix error in NamedDeclPrinterTest
Apr 5 2019, 12:16 PM
dgoldman committed rL357799: Fix error in NamedDeclPrinterTest.
Fix error in NamedDeclPrinterTest
Apr 5 2019, 12:16 PM
dgoldman committed rC357799: Fix error in NamedDeclPrinterTest.
Fix error in NamedDeclPrinterTest
Apr 5 2019, 12:15 PM
dgoldman closed D60326: Fix error in NamedDeclPrinterTest.
Apr 5 2019, 12:15 PM · Restricted Project
dgoldman created D60326: Fix error in NamedDeclPrinterTest.
Apr 5 2019, 11:23 AM · Restricted Project

Apr 4 2019

dgoldman committed rG19d21854e92e: Special case ObjCPropertyDecl for printing (authored by dgoldman).
Special case ObjCPropertyDecl for printing
Apr 4 2019, 1:12 PM
dgoldman closed D56924: Special case ObjCPropertyDecl for printing.

Closed via rL357720

Apr 4 2019, 1:12 PM · Restricted Project
dgoldman committed rL357720: Special case ObjCPropertyDecl for printing.
Special case ObjCPropertyDecl for printing
Apr 4 2019, 1:11 PM
dgoldman committed rC357720: Special case ObjCPropertyDecl for printing.
Special case ObjCPropertyDecl for printing
Apr 4 2019, 1:11 PM
dgoldman updated the diff for D56924: Special case ObjCPropertyDecl for printing.

Rebase

Apr 4 2019, 1:05 PM · Restricted Project

Apr 2 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

ping

Apr 2 2019, 11:52 AM · Restricted Project

Mar 19 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

ping

Mar 19 2019, 12:11 PM · Restricted Project
dgoldman added a comment to D57965: Clean up ObjCPropertyDecl printing.

friendly ping

Mar 19 2019, 12:11 PM · Restricted Project, Restricted Project

Mar 12 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

ping

Mar 12 2019, 8:44 AM · Restricted Project

Mar 5 2019

dgoldman updated the summary of D57965: Clean up ObjCPropertyDecl printing.
Mar 5 2019, 7:35 AM · Restricted Project, Restricted Project
dgoldman added a reviewer for D57965: Clean up ObjCPropertyDecl printing: jkorous.
Mar 5 2019, 7:35 AM · Restricted Project, Restricted Project
dgoldman updated the diff for D57965: Clean up ObjCPropertyDecl printing.
  • Fix broken test by last change
Mar 5 2019, 7:29 AM · Restricted Project, Restricted Project
dgoldman updated the diff for D57965: Clean up ObjCPropertyDecl printing.
  • Add more tests and improved printing of pointers
Mar 5 2019, 7:26 AM · Restricted Project, Restricted Project

Mar 4 2019

dgoldman added a comment to D57965: Clean up ObjCPropertyDecl printing.

Hi David,
I am just wondering - while you're here would you mind adding couple more tests? It would be great to have a test for each attribute.

Also, what do you think about Ben's suggestion? I think it would be nice to be consistent with the style Objective-C documentation uses:
https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/EncapsulatingData/EncapsulatingData.html

Mar 4 2019, 1:18 PM · Restricted Project, Restricted Project
dgoldman added a reviewer for D57965: Clean up ObjCPropertyDecl printing: akyrtzi.
Mar 4 2019, 8:26 AM · Restricted Project, Restricted Project
dgoldman added a comment to D57965: Clean up ObjCPropertyDecl printing.

Friendly ping

Mar 4 2019, 8:26 AM · Restricted Project, Restricted Project

Feb 28 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

friendly ping, think this is good to go now

Feb 28 2019, 10:26 AM · Restricted Project

Feb 27 2019

dgoldman closed D58062: Support framework import/include auto-completion.

Closed via rL355008

Feb 27 2019, 9:48 AM · Restricted Project
dgoldman committed rG3e804d258198: Support framework import/include auto-completion (authored by dgoldman).
Support framework import/include auto-completion
Feb 27 2019, 9:40 AM
dgoldman committed rC355008: Support framework import/include auto-completion.
Support framework import/include auto-completion
Feb 27 2019, 9:40 AM
dgoldman committed rL355008: Support framework import/include auto-completion.
Support framework import/include auto-completion
Feb 27 2019, 9:39 AM

Feb 25 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

Please add a test that covers the '(class extension)' output as well.

Feb 25 2019, 10:25 AM · Restricted Project
dgoldman retitled D56924: Special case ObjCPropertyDecl for printing from Handle ObjCCategoryDecl class extensions for print to Special case ObjCPropertyDecl for printing.
Feb 25 2019, 10:24 AM · Restricted Project
dgoldman updated the diff for D56924: Special case ObjCPropertyDecl for printing.
  • Remove (class extension) as it's no longer needed
Feb 25 2019, 10:21 AM · Restricted Project

Feb 22 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

ping, looking to get this in to fix a clangd assertion failure

Feb 22 2019, 2:06 PM · Restricted Project

Feb 15 2019

dgoldman added a comment to D58062: Support framework import/include auto-completion.

Great, thank you! Want me to land this?

(You can certainly get your own commit access at this point if you like: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access and point at a couple of your patches)

Feb 15 2019, 9:33 AM · Restricted Project

Feb 14 2019

dgoldman added a comment to D58062: Support framework import/include auto-completion.

added test

Feb 14 2019, 1:14 PM · Restricted Project
dgoldman updated the diff for D58062: Support framework import/include auto-completion.
  • Add test and fix subfolder bug
Feb 14 2019, 1:14 PM · Restricted Project

Feb 12 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

ping

Feb 12 2019, 1:56 PM · Restricted Project
dgoldman updated the diff for D58062: Support framework import/include auto-completion.
  • Misc fixes
Feb 12 2019, 11:29 AM · Restricted Project

Feb 11 2019

dgoldman created D58062: Support framework import/include auto-completion.
Feb 11 2019, 9:20 AM · Restricted Project
dgoldman added a reviewer for D57965: Clean up ObjCPropertyDecl printing: arphaman.
Feb 11 2019, 7:53 AM · Restricted Project, Restricted Project

Feb 8 2019

dgoldman created D57965: Clean up ObjCPropertyDecl printing.
Feb 8 2019, 11:11 AM · Restricted Project, Restricted Project

Feb 5 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

Do you know if this have an effect on the output of completion results or other tooling-based output?

A couple of requests:

  • This behavior should be controlled by a printing policy flag SupressUnwrittenScope (specifically for the '::(class extension)').
  • I also agree with Sam's comment. The property should still be qualified by the class name as well, e.g. Obj::(class extension)::property.
Feb 5 2019, 10:19 AM · Restricted Project
dgoldman updated the diff for D56924: Special case ObjCPropertyDecl for printing.
  • Output class scope for ObjCPropertyDecl
Feb 5 2019, 10:07 AM · Restricted Project

Jan 23 2019

dgoldman added a comment to D56924: Special case ObjCPropertyDecl for printing.

This is definitely an improvement, though I don't know if it's *right*. @akyrtzi, thoughts?

Jan 23 2019, 11:20 AM · Restricted Project
dgoldman added a comment to D56916: Fix crash due to ObjCPropertyDecl.

It looks like Container::_magic is a platform-dependent completion, I don't have it on Linux, but http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/42665 fails because it's not in the list.
Submitted rL351943 to workaround the failure. @dgoldman, any idea why completion might be there on some platforms, but not the others?

Jan 23 2019, 7:55 AM

Jan 22 2019

dgoldman added reviewers for D56924: Special case ObjCPropertyDecl for printing: akyrtzi, sammccall.
Jan 22 2019, 1:06 PM · Restricted Project
dgoldman updated the diff for D56924: Special case ObjCPropertyDecl for printing.
  • Add test
Jan 22 2019, 1:05 PM · Restricted Project
dgoldman added a comment to D56916: Fix crash due to ObjCPropertyDecl.

Unfortunately I can't get ninja check-clangd to build:

Looks like clang-tools-extra uses an old revision. Rebasing after rL350916 should do the trick.

Jan 22 2019, 10:29 AM
dgoldman updated the diff for D56916: Fix crash due to ObjCPropertyDecl.
  • FIXME and dyn_cast
  • use auto
  • Add test
Jan 22 2019, 10:27 AM
dgoldman added a comment to D56916: Fix crash due to ObjCPropertyDecl.

Good point, @aaron.ballman! @dgoldman, could you please add a test case?

Jan 22 2019, 8:10 AM
dgoldman updated the diff for D56916: Fix crash due to ObjCPropertyDecl.
  • use auto
Jan 22 2019, 8:10 AM

Jan 18 2019

dgoldman created D56924: Special case ObjCPropertyDecl for printing.
Jan 18 2019, 11:29 AM · Restricted Project
dgoldman updated the diff for D56916: Fix crash due to ObjCPropertyDecl.
  • FIXME and dyn_cast
Jan 18 2019, 10:58 AM
dgoldman created D56916: Fix crash due to ObjCPropertyDecl.
Jan 18 2019, 8:46 AM

Nov 14 2018

dgoldman added a comment to D53900: [CodeComplete] Penalize inherited ObjC properties for auto-completion.

@sammccall to land this

Nov 14 2018, 10:48 AM

Nov 13 2018

dgoldman added a comment to D53934: [clangd] Improve code completion for ObjC methods.

Since I don't have commit access, @sammccall will land this.

Nov 13 2018, 10:17 AM

Nov 12 2018

dgoldman updated the diff for D53934: [clangd] Improve code completion for ObjC methods.

CodeCompleteTests fixes

Nov 12 2018, 12:55 PM

Nov 8 2018

dgoldman added a comment to D53900: [CodeComplete] Penalize inherited ObjC properties for auto-completion.

Since I don't have commit access, sammccall will land this

Nov 8 2018, 10:19 AM

Oct 31 2018

dgoldman created D53934: [clangd] Improve code completion for ObjC methods.
Oct 31 2018, 7:58 AM

Oct 30 2018

dgoldman added a reviewer for D53900: [CodeComplete] Penalize inherited ObjC properties for auto-completion: akyrtzi.
Oct 30 2018, 3:47 PM
dgoldman added reviewers for D53900: [CodeComplete] Penalize inherited ObjC properties for auto-completion: jkorous, sammccall.
Oct 30 2018, 3:41 PM
dgoldman created D53900: [CodeComplete] Penalize inherited ObjC properties for auto-completion.
Oct 30 2018, 2:24 PM