Hey, are you still planning to work on this? Otherwise, is it okay if I take over this patch to implement this feature?

Respect ImportInsertions flag in IncludeFixer

Update comment + default value

Update comment + test

Minor fixes for review, moving stuff around

Don't pass ASTSignals through ParsedAST

Fixes for review

Add tests

Use raw string literal

Update test

Fixes for review + fix diffbase

Fixes + hopefully proper diffbase

Rebase

Rebase

Fixes for review

Run clang-format

Rebase

Rebase

Fixes for review

Fixes for review

In D138047#3930211, @kadircet wrote:

yeah unfortunately testing this is hard, but bug&fix are obvious so it's fine to land without a test.

but i think we should rather fix the broken call site at clang-tools-extra/clangd/ParsedAST.cpp and move BuildDir to outer scope where it'll outlive IncludeFixer (~line 468).

Fix in ParsedAST.cpp

LMK of the best way to add a test for this, maybe I can somehow make a test with relative path arguments?

Run clang format

Fix serialization and isSelfContainedHeader

Also LMK if you want more in this change (such as a flag to control it, just not sure where it should live + what it should be called).

Fixes for review

Change IncludeTypes to be a bitset

Address comment

Run clang-format again

Fix strings + test

Run clang format

In D132962#3761463, @kadircet wrote:

can you also add test cases for the other two (filtering both for speculative index queries/regular ones, and making sure we don't suggest symbols from index for category names), so that we don't regress in the future?

Add tests

Ah my bad didn't realize you hadn't accepted this, was there anything else you wanted me to change?

Run clang-format

Fix broken test and swap to AST.tuPath()

Run clang-format

Minor fixes for review (some still pending based on discussion)

Minor grammar update to comment

Run clang-format

For more context see the discussion on b/187405187

Revert unintended change in symbol-info.test

• Use codeCompletionString(Result) for RK_Pattern