This is an archive of the discontinued LLVM Phabricator instance.

[ARM][LowOverheadLoops] Change predicate inspection
ClosedPublic

Authored by samparker on Jan 10 2020, 6:51 AM.

Details

Summary

Use the already provided helper function to get the operand type so that we can detect whether the vpr is being used as a predicate or not. Also use existing helpers to get the predicate indices when we converting the vpt blocks.

Diff Detail

Event Timeline

samparker created this revision.Jan 10 2020, 6:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2020, 6:51 AM
SjoerdMeijer accepted this revision.Jan 13 2020, 5:53 AM

LGTM, with just one nit:

At first sight, this looked like a NFC, but it is not. So perhaps it's good to comment somewhere in the description, code, and/or the test case what the motivation is for this change.

This revision is now accepted and ready to land.Jan 13 2020, 5:53 AM
This revision was automatically updated to reflect the committed changes.