Page MenuHomePhabricator

[libcxx] [test] Portability fix for some locale-dependent tests.
ClosedPublic

Authored by amakc11 on Jan 9 2020, 7:36 AM.

Details

Summary

Tests for std::system_error constructor marked as "slightly non-portable". One (but not the only one) reason for such non-portability is that these tests assume the default locale to be set to "C" (or "POSIX"). However, the default locale for the process depends on OS and environment. This patch adds explicit setting of the correct locale expected by the tests.

Diff Detail

Event Timeline

amakc11 created this revision.Jan 9 2020, 7:36 AM
Herald added a project: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 14 2020, 6:38 AM

Thanks for the fix! Can you please provide "First Last <email@domain.com>" for the Git commit information?

This revision is now accepted and ready to land.May 14 2020, 6:38 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 6:38 AM
This revision now requires review to proceed.May 14 2020, 6:38 AM
ldionne accepted this revision.May 14 2020, 6:39 AM
This revision is now accepted and ready to land.May 14 2020, 6:39 AM
This revision was automatically updated to reflect the committed changes.