This is an archive of the discontinued LLVM Phabricator instance.

Differential D72419

add a missing dependency for Linalg conversion
ClosedPublic

Authored by schweitz on Jan 8 2020, 2:59 PM.

Details

Reviewers
ftynse
mehdi_amini
jpienaar
Commits
rG016bf03ef6fc: [mlir] add a missing dependency for Linalg conversion
Summary

We were seeing some occasional build failures that would come and go. It appeared to be this missing dependence.

Diff Detail

Event Timeline

schweitz created this revision.Jan 8 2020, 2:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2020, 2:59 PM
Herald added subscribers: llvm-commits, lucyrfox, mgester and 7 others. · View Herald Transcript
ftynse accepted this revision.Jan 8 2020, 11:04 PM
This revision is now accepted and ready to land.Jan 8 2020, 11:04 PM
schweitz added a comment.Jan 9 2020, 10:47 AM

Thanks for the quick review, Alex. Can you commit this? I don't have privileges. Thanks again.

Closed by commit rG016bf03ef6fc: [mlir] add a missing dependency for Linalg conversion (authored by schweitz, committed by ftynse). · Explain WhyJan 9 2020, 2:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
Conversion/
LinalgToLLVM/
1 line

Diff 236915

mlir/lib/Conversion/LinalgToLLVM/CMakeLists.txt

add_llvm_library(MLIRLinalgToLLVM add_llvm_library(MLIRLinalgToLLVM
LinalgToLLVM.cpp LinalgToLLVM.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToLLVM ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToLLVM
) )
set(LIBS set(LIBS
MLIRLinalg
MLIRLLVMIR MLIRLLVMIR
MLIRTransforms MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
add_dependencies(MLIRLinalgToLLVM ${LIBS}) add_dependencies(MLIRLinalgToLLVM ${LIBS})
target_link_libraries(MLIRLinalgToLLVM ${LIBS}) target_link_libraries(MLIRLinalgToLLVM ${LIBS})