Page MenuHomePhabricator

[clangd] Respect `--sysroot` argument if it is set
ClosedPublic

Authored by dgoldman on Jan 8 2020, 2:04 PM.

Details

Summary
  • Since --sysroot is a superset of the -isysroot argument, we shouldn't add the -isysroot if we detect a --sysroot flag.

Diff Detail

Event Timeline

dgoldman created this revision.Jan 8 2020, 2:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2020, 2:04 PM

Unit tests: pass. 61323 tests passed, 0 failed and 736 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

sammccall accepted this revision.Jan 8 2020, 2:30 PM

Thanks!

I wonder what accident of history led to the different number of dashes between the flags, weird.

This revision is now accepted and ready to land.Jan 8 2020, 2:30 PM
This revision was automatically updated to reflect the committed changes.