Add zero_extendi and sign_extendi to intrinsic namespace

[pruthviIntel]

Summary

• update zero_extendi and sign_extendi in edsc/intrinsic namespace
• Builder API test for zero_extendi and sign_extendi

[nicolasvasilache]

mlir/test/EDSC/builder-api-test.cpp

515

can both tests be folded into a single test?
Or better yet into a previously exisiting test to avoid duplicating boilerplate?

[pruthviIntel]

• reduce boiler plate code by folding the zero_extendi, sign_extendi to a single builder API test

[pruthviIntel]

mlir/test/EDSC/builder-api-test.cpp

515

@nicolasvasilache sure, will fold both of them under a single test.

[nicolasvasilache]

Thanks!

[pruthviIntel]

@nicolasvasilache can you merge the PR, I don't have the commit access :)

[ftynse]

Please let us know which email to associate with your commit

[pruthviIntel]

[e-mail] , this email should be good.

mlir/include/mlir/EDSC/Intrinsics.h

 using memref_cast = ValueBuilder<MemRefCastOp>;
 using ret = OperationBuilder<ReturnOp>;
 using select = ValueBuilder<SelectOp>;
 using std_load = ValueBuilder<LoadOp>;
 using std_store = OperationBuilder<StoreOp>;
 using subi = ValueBuilder<SubIOp>;
 using tanh = ValueBuilder<TanhOp>;
 using view = ValueBuilder<ViewOp>;
+using zero_extendi = ValueBuilder<ZeroExtendIOp>;
+using sign_extendi = ValueBuilder<SignExtendIOp>;
 
 /// Branches into the mlir::Block* captured by BlockHandle `b` with `operands`.
 ///
 /// Prerequisites:
 ///   All Handles have already captured previously constructed IR objects.
 OperationHandle br(BlockHandle bh, ArrayRef<ValueHandle> operands);
 
 /// Creates a new mlir::Block* and branches to it from the current block.

mlir/test/EDSC/builder-api-test.cpp

TEST_FUNC(insertion_in_block) {
   // CHECK: {{.*}} = constant 2 : i32
   // CHECK: ^bb1:   // no predecessors
   // CHECK: {{.*}} = constant 1 : i32
   // clang-format on
   f.print(llvm::outs());
   f.erase();
 }
 
+TEST_FUNC(zero_and_sign_extendi_op_i1_to_i8) {
+  using namespace edsc;
+  using namespace edsc::intrinsics;
+  using namespace edsc::op;
+  auto i1Type = IntegerType::get(1, &globalContext());
+  auto i8Type = IntegerType::get(8, &globalContext());
+  auto memrefType = MemRefType::get({}, i1Type, {}, 0);
+  auto f = makeFunction("zero_and_sign_extendi_op", {}, {memrefType, memrefType});
+
+  OpBuilder builder(f.getBody());
+  ScopedContext scope(builder, f.getLoc());
+  IndexedValue A(f.getArgument(0));
+  IndexedValue B(f.getArgument(1));
+  // clang-format off
+  edsc::intrinsics::zero_extendi(*A, i8Type);
+  edsc::intrinsics::sign_extendi(*B, i8Type);
+  // CHECK-LABEL: @zero_and_sign_extendi_op
+  //      CHECK:     %[[SRC1:.*]] = affine.load
+  //      CHECK:     zexti %[[SRC1]] : i1 to i8
+  //      CHECK:     %[[SRC2:.*]] = affine.load
+  //      CHECK:     sexti %[[SRC2]] : i1 to i8
+  // clang-format on
+  f.print(llvm::outs());
+  f.erase();
+}
+
 TEST_FUNC(select_op_i32) {
   using namespace edsc;
   using namespace edsc::intrinsics;
   using namespace edsc::op;
   auto f32Type = FloatType::getF32(&globalContext());
   auto memrefType = MemRefType::get({-1, -1}, f32Type, {}, 0);
   auto f = makeFunction("select_op", {}, {memrefType});
 
AffineLoopNestBuilder({&i, &j}, {zero, zero}, {one, one}, {1, 1})([&]{
     //      i == zero, ValueHandle(A(zero, zero)), ValueHandle(ValueA(i, j)))
     edsc::intrinsics::select(i == zero, *A(zero, zero), *A(i, j));
   });
 
   // CHECK-LABEL: @select_op
   //      CHECK: affine.for %{{.*}} = 0 to 1 {
   // CHECK-NEXT:   affine.for %{{.*}} = 0 to 1 {
   //  CHECK-DAG:     {{.*}} = cmpi "eq"
   //  CHECK-DAG:     {{.*}} = affine.load
   //  CHECK-DAG:     {{.*}} = affine.load
   // CHECK-NEXT:     {{.*}} = select
   // clang-format on
   f.print(llvm::outs());
   f.erase();
 }
 
 TEST_FUNC(select_op_f32) {