Diff Detail
Event Timeline
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | ||
---|---|---|
1500–1511 | Could you please add the intended high-level logic here in a comment? I admittedly haven't thought this through fully, but I find this code suspicious: doubles have more than twice the mantissa bits of floats, so I don't think two single-precision fptouis can be sufficient to capture all the precision that is there. |
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | ||
---|---|---|
1500–1511 | That would require me to have any idea what the high level logic is here. This is just copied from the existing legalization, which has no comments |
Okay, so the SelectionDAG is likely broken then :)
... which makes it reasonable to go ahead here for GlobalISel parity. Please add a TODO comment to verify and document the high-level logic, though.
Could you please add the intended high-level logic here in a comment?
I admittedly haven't thought this through fully, but I find this code suspicious: doubles have more than twice the mantissa bits of floats, so I don't think two single-precision fptouis can be sufficient to capture all the precision that is there.