This is an archive of the discontinued LLVM Phabricator instance.

Differential D72255

Fix compiler extension example cmake integration
ClosedPublic

Authored by serge-sans-paille on Jan 6 2020, 5:30 AM.

Details

Reviewers
svenvh
fhahn
Commits
rG5a9c24b5721b: Fix compiler extension example cmake integration
Summary
  • Do not add it to the Export file
  • Update install target

Diff Detail

Event Timeline

serge-sans-paille created this revision.Jan 6 2020, 5:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2020, 5:30 AM
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
serge-sans-paille added a reviewer: fhahn.Jan 6 2020, 5:31 AM
svenvh accepted this revision.Jan 6 2020, 9:32 AM

LGTM (for what it's worth as I'm not an expert in this area), thanks!

This revision is now accepted and ready to land.Jan 6 2020, 9:32 AM
Closed by commit rG5a9c24b5721b: Fix compiler extension example cmake integration (authored by serge-sans-paille). · Explain WhyJan 7 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
examples/
Bye/
6 lines

Diff 236531

llvm/examples/Bye/CMakeLists.txt

add_llvm_pass_plugin(Bye add_llvm_pass_plugin(Bye
Bye.cpp Bye.cpp
DEPENDS DEPENDS
intrinsics_gen intrinsics_gen
BUILDTREE_ONLY
) )
if (LLVM_LINK_LLVM_DYLIB) if (LLVM_LINK_LLVM_DYLIB)
target_link_libraries(Bye PUBLIC LLVM) target_link_libraries(Bye PUBLIC LLVM)
else() else()
target_link_libraries(Bye target_link_libraries(Bye
PUBLIC PUBLIC
LLVMSupport LLVMSupport
LLVMCore LLVMCore
LLVMipo LLVMipo
LLVMPasses LLVMPasses
) )
endif() endif()
if( LLVM_BUILD_EXAMPLES )
install(TARGETS ${name} RUNTIME DESTINATION examples)
endif()
set_target_properties(${name} PROPERTIES FOLDER "Examples")