Page MenuHomePhabricator

[OpenMP] affinity little fix for FreeBSD
ClosedPublic

Authored by devnexen on Jan 3 2020, 2:06 AM.

Details

Summary
  • pthread affinity np has different semantic than sched affinity counterpart. On success returns strictly 0.

Diff Detail

Event Timeline

devnexen created this revision.Jan 3 2020, 2:06 AM
devnexen created this object with edit policy "Administrators".
Herald added a project: Restricted Project. · View Herald Transcript

LGTM.

If possible, please also fix typo in FreeBSD-related code on line 289 of z_Linux_util.cpp (< is used instead of comma).

Thanks.

(though looks like I cannot accept this review, not sure why)

protze.joachim added a subscriber: protze.joachim.EditedJan 20 2020, 9:22 AM

Code LGTM, if possible apply clang-format.

I cannot accept, too. I cannot even add myself as reviewer

This revision was not accepted when it landed; it landed in state Needs Review.Jan 20 2020, 10:54 AM
This revision was automatically updated to reflect the committed changes.