This is an archive of the discontinued LLVM Phabricator instance.

Differential D71922

[MLIR] [NFC] fix unused var warning
ClosedPublic

Authored by bondhugula on Dec 27 2019, 2:22 AM.

Details

Reviewers
rriddle
mehdi_amini
ftynse
Commits
rGbe775a003856: [MLIR] [NFC] fix unused var warning
Summary

Fix this warning:
`
[69/106] Building CXX object tools/mlir/lib/Dialect/StandardOps/CMakeFiles/MLIRStandardOps.dir/Ops.cpp.o
/home/uday/llvm-project/mlir/lib/Dialect/StandardOps/Ops.cpp: In member function ‘virtual mlir::PatternMatchResult {anonymous}::ViewOpShapeFolder::matchAndRewrite(mlir::ViewOp, mlir::PatternRewriter&) const’:
/home/uday/llvm-project/mlir/lib/Dialect/StandardOps/Ops.cpp:2575:14: warning: variable ‘dynamicOffsetOperandCount’ set but not used [-Wunused-but-set-variable]
2575 | unsigned dynamicOffsetOperandCount = 0;
`

Diff Detail

Event Timeline

bondhugula created this revision.Dec 27 2019, 2:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 27 2019, 2:22 AM
Herald added subscribers: llvm-commits, shauheen, burmako, jpienaar. · View Herald Transcript
ftynse accepted this revision.Dec 27 2019, 2:27 AM
This revision is now accepted and ready to land.Dec 27 2019, 2:27 AM
Closed by commit rGbe775a003856: [MLIR] [NFC] fix unused var warning (authored by bondhugula, committed by ftynse). · Explain WhyDec 27 2019, 3:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
Dialect/
StandardOps/
1 line

Diff 235402

mlir/lib/Dialect/StandardOps/Ops.cpp

Show First 20 Lines • Show All 2,507 Lines • ▼ Show 20 Lines PatternMatchResult matchAndRewrite(ViewOp viewOp,
// Regenerate strided layout map with 'newStrides' and 'newOffset'. // Regenerate strided layout map with 'newStrides' and 'newOffset'.
map = makeStridedLinearLayoutMap(newStrides, newOffset, map = makeStridedLinearLayoutMap(newStrides, newOffset,
rewriter.getContext()); rewriter.getContext());
// Create new memref type with constant folded dims and/or offset/strides. // Create new memref type with constant folded dims and/or offset/strides.
auto newMemRefType = auto newMemRefType =
MemRefType::get(newShapeConstants, memrefType.getElementType(), {map}, MemRefType::get(newShapeConstants, memrefType.getElementType(), {map},
memrefType.getMemorySpace()); memrefType.getMemorySpace());
(void)dynamicOffsetOperandCount; // unused in opt mode
assert(static_cast<int64_t>(newOperands.size()) == assert(static_cast<int64_t>(newOperands.size()) ==
dynamicOffsetOperandCount + newMemRefType.getNumDynamicDims()); dynamicOffsetOperandCount + newMemRefType.getNumDynamicDims());
// Create new ViewOp. // Create new ViewOp.
auto newViewOp = rewriter.create<ViewOp>(viewOp.getLoc(), newMemRefType, auto newViewOp = rewriter.create<ViewOp>(viewOp.getLoc(), newMemRefType,
viewOp.getOperand(0), newOperands); viewOp.getOperand(0), newOperands);
// Insert a cast so we have the same type as the old memref type. // Insert a cast so we have the same type as the old memref type.
rewriter.replaceOpWithNewOp<MemRefCastOp>(droppedOperands, viewOp, rewriter.replaceOpWithNewOp<MemRefCastOp>(droppedOperands, viewOp,
▲ Show 20 Lines • Show All 461 Lines • Show Last 20 Lines