This is an archive of the discontinued LLVM Phabricator instance.

[X86FixupSetCC] Remember the preceding eflags defining instruction while we're scanning the basic block instead of looking back for it.
ClosedPublic

Authored by craig.topper on Dec 24 2019, 9:38 PM.

Details

Summary

We're already scanning forward through the basic block. Might as
well just remember eflags defs instead of doing a bounded search
backwards later.

Based on a comment in D71841.

Diff Detail

Event Timeline

craig.topper created this revision.Dec 24 2019, 9:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 24 2019, 9:38 PM
Herald added a subscriber: hiraditya. · View Herald Transcript

Remove some now dead code.

craig.topper retitled this revision from [X86FixupSetCC] Remove the preceding eflags defining instruction while we're scanning the basic block instead of looking back for it. to [X86FixupSetCC] Remember the preceding eflags defining instruction while we're scanning the basic block instead of looking back for it..Dec 24 2019, 9:41 PM
uweigand accepted this revision.Dec 25 2019, 4:22 AM

Otherwise, this LGTM.

llvm/lib/Target/X86/X86FixupSetCC.cpp
49

This is now also dead.

This revision is now accepted and ready to land.Dec 25 2019, 4:22 AM
This revision was automatically updated to reflect the committed changes.