This is an archive of the discontinued LLVM Phabricator instance.

[test][ELF] Verify debug line corruption messages are printed once
ClosedPublic

Authored by jhenderson on Dec 20 2019, 6:03 AM.

Details

Summary

LLD warns if it encounters malformed debug data when parsing line information for an undefined reference. We only want to warn once.

This patch adds additional checking to make sure the warnings are printed only once, both for variables within the same program and variables in later line programs.

Related to D71702 which will touch this file.

Diff Detail

Event Timeline

jhenderson created this revision.Dec 20 2019, 6:03 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: emaste. · View Herald Transcript
grimar accepted this revision.Dec 20 2019, 7:34 AM

LGTM

This revision is now accepted and ready to land.Dec 20 2019, 7:34 AM
MaskRay accepted this revision.Dec 20 2019, 8:26 PM
MaskRay added inline comments.
lld/test/ELF/undef.s
55

Add -NEXT: by the way?

jhenderson marked an inline comment as done.Jan 2 2020, 9:09 AM
jhenderson added inline comments.
lld/test/ELF/undef.s
55

I'll do this in a separate follow-up, as the rest of the checks in this file are not -NEXT currently.

This revision was automatically updated to reflect the committed changes.