This is an archive of the discontinued LLVM Phabricator instance.

Differential D71674

[clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP
ClosedPublic

Authored by mgorny on Dec 18 2019, 1:17 PM.

Details

Reviewers
baloghadamsoftware
jdoerfert
ABataev
lebedev.ri
Commits
rG4121399c1229: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP
Summary

Use LLVM_LINK_COMPONENTS to link the FrontendOpenMP library
instead of passing it explicitly to LINK_LIBS. This fixes duplicating
the library when clang-tidy is linked to LLVM dylib.

Diff Detail

Event Timeline

mgorny created this revision.Dec 18 2019, 1:17 PM
Herald added a reviewer: lebedev.ri. · View Herald TranscriptDec 18 2019, 1:17 PM
Herald added subscribers: lebedev.ri, guansong, rnkovacs. · View Herald Transcript
lebedev.ri accepted this revision.Dec 18 2019, 1:27 PM

LG
I think this is correct solution.

This revision is now accepted and ready to land.Dec 18 2019, 1:27 PM
Closed by commit rG4121399c1229: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP (authored by mgorny). · Explain WhyDec 18 2019, 1:41 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2019, 1:41 PM

Revision Contents

PathSize
clang-tools-extra/
clang-tidy/
openmp/
5 lines

Diff 234604

clang-tools-extra/clang-tidy/openmp/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support) set(LLVM_LINK_COMPONENTS
FrontendOpenMP
Support)
add_clang_library(clangTidyOpenMPModule add_clang_library(clangTidyOpenMPModule
ExceptionEscapeCheck.cpp ExceptionEscapeCheck.cpp
OpenMPTidyModule.cpp OpenMPTidyModule.cpp
UseDefaultNoneCheck.cpp UseDefaultNoneCheck.cpp
LINK_LIBS LINK_LIBS
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangTidy clangTidy
clangTidyUtils clangTidyUtils
LLVMFrontendOpenMP
) )