Page MenuHomePhabricator

[libcxx] Fix include paths in fuzzing/partial_sort.pass.cpp
ClosedPublic

Authored by miyuki on Dec 13 2019, 3:16 AM.

Details

Summary

When testing an installed (out-of-tree) version of libc++, the
"libcxx/fuzzing/partial_sort.pass.cpp" test fails because of missing
include files "../fuzzing/fuzzing.{h,cpp}". This happens because in
the source tree "../fuzzing" can be accessed as
"libcxx/include/../fuzzing", but with the installed library this does
not work.

This patch fixes the issue by changing the path to be relative from
the `libcxx/test/fuzzing" directory.

Diff Detail

Event Timeline

miyuki created this revision.Dec 13 2019, 3:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2019, 3:16 AM

Unit tests: pass. 60837 tests passed, 0 failed and 726 were skipped.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or apply this patch.

Build artifacts: console-log.txt, CMakeCache.txt, clang-format.patch, test-results.xml, diff.json

michaelplatings accepted this revision.Dec 17 2019, 3:37 AM
This revision is now accepted and ready to land.Dec 17 2019, 3:37 AM
This revision was automatically updated to reflect the committed changes.

Please don't commit to libc++ w/o approval from one of the "approvers": @mclow.lists, @EricWF or @ldionne .

@michaelplatings, please don't approve libc++ patches.
I appreciate the reviews, and you should give feedback, but please don't approve (say LGTM instead).

Does this change break OSS-Fuzz? Did anyone try?

Does this change break OSS-Fuzz? Did anyone try?

I did not know that these tests are supposed to interact with an external component. Sorry about that. I'll wait for approval from the libc++ approvers in my future patches.