This is an archive of the discontinued LLVM Phabricator instance.

[ARM][MVE] findVCMPToFoldIntoVPS. NFC.
ClosedPublic

Authored by SjoerdMeijer on Dec 11 2019, 1:56 AM.

Details

Summary

While grepping for some inspriration, I came across this function, and I found the logic a bit difficult to follow, so I simplified it a bit.

Diff Detail

Event Timeline

SjoerdMeijer created this revision.Dec 11 2019, 1:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 11 2019, 1:56 AM

If this is going to be rewritten, I'd suggest using RDA here which should hopefully be able to get your the reaching def of the VPR in a single call. Two more calls for checking for defs between instructions.

SjoerdMeijer added a comment.EditedDec 12 2019, 12:09 AM

it's not that this is important, but the code would benefit from a rewrite. This was a more easy/straightforward change, but agreed that RDA would be even better, so will see what I can do.

Now using RDA

samparker added inline comments.Dec 12 2019, 4:13 AM
llvm/lib/Target/ARM/MVEVPTBlockPass.cpp
167

RDA...?

Yep, more RDA

samparker accepted this revision.Dec 12 2019, 5:59 AM

Cheers! Just please remove TRI before committing.

llvm/lib/Target/ARM/MVEVPTBlockPass.cpp
138

Unused argument and looks like the formatting is off below.

This revision is now accepted and ready to land.Dec 12 2019, 5:59 AM
This revision was automatically updated to reflect the committed changes.