As discussed in https://reviews.llvm.org/D69998, we miss to create some dependency edges if chained more than 2 instructions. Adding an assertion here if someone want to chain more than 2 instructions.
Details
Details
- Reviewers
fhahn evandro jsji - Group Reviewers
Restricted Project - Commits
- rG05b0c76aa76e: [NFC][MacroFusion] Adding the assertion if someone want to fuse more than 2…
Diff Detail
Diff Detail
Event Timeline
Comment Actions
LGTM, thanks!
llvm/lib/CodeGen/MacroFusion.cpp | ||
---|---|---|
80 | nit: maybe it would be slightly better to put a whole sentence here, e.g. something like 'Currently we only support chaining together 2 instructions.' |
llvm/lib/CodeGen/MacroFusion.cpp | ||
---|---|---|
80 | ok, I will update it when commit it. |
nit: maybe it would be slightly better to put a whole sentence here, e.g. something like 'Currently we only support chaining together 2 instructions.'