This is an archive of the discontinued LLVM Phabricator instance.

[ModuloSchedule] Fix data types in ModuloScheduleExpander::isLoopCarried
ClosedPublic

Authored by masakiarai on Dec 6 2019, 8:30 AM.

Details

Summary

The cycle values in modulo scheduling results can be negative.
The result of ModuloSchedule::getCycle() must be received as an int type.

Diff Detail

Event Timeline

masakiarai created this revision.Dec 6 2019, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2019, 8:30 AM
jmolloy accepted this revision.Dec 6 2019, 8:31 AM
This revision is now accepted and ready to land.Dec 6 2019, 8:31 AM
ThomasRaoux accepted this revision.Dec 6 2019, 8:57 AM

Thanks for catching that!

Thank you very much for your quick review.
I don't have commit access.
Could you commit this patch?

This revision was automatically updated to reflect the committed changes.

Thank you very much for your quick review.
I don't have commit access.
Could you commit this patch?

Committed:
https://github.com/llvm/llvm-project/commit/caabb713ea157f8c449c8d3eb00410bbef734a22