Page MenuHomePhabricator

masakiarai (Masaki Arai)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2018, 5:19 AM (129 w, 5 d)

Recent Activity

Sep 29 2020

masakiarai updated the diff for D88293: [ControlDependentDCE] Add Control Dependent DCE pass.

Test duplicate-conditional.ll succeeds in my local build.
I will investigate this as it may be a severe bug.

Sep 29 2020, 10:01 PM · Restricted Project

Sep 25 2020

masakiarai added a comment to D88293: [ControlDependentDCE] Add Control Dependent DCE pass.

That said, I still am not convinced this is best implemented in a new pass. Isn't the idea here that we have the value of a branch condition available for a subset of the incoming paths? That sounds like it would compose well with other ways through which we can know the value of a conditional for a subset of the incoming paths w/o having multiple branches with the same condition:

Sep 25 2020, 8:51 PM · Restricted Project
masakiarai added a comment to D88293: [ControlDependentDCE] Add Control Dependent DCE pass.

Considering only the DCE's feature, I think the ADCE pass is close to this pass's purpose.
The big difference between this pass and others is that this pass duplicates the basic block to isolate the control flow.
This feature can promote loop optimizations by isolating the control flow that does not enter loops out of the kernel part when there is a sequence of multiple loops in numerical applications.
However, this first version duplicates basic blocks only in the conservative case where the performance is definitely improved.
This pass needs to duplicate basic blocks more aggressively and selectively to facilitate loop optimizations.

Sep 25 2020, 10:34 AM · Restricted Project
masakiarai abandoned D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results.

I closed this revision as the following revision will reconstruct this anew.

Sep 25 2020, 9:38 AM
masakiarai updated the diff for D88293: [ControlDependentDCE] Add Control Dependent DCE pass.

I corrected the description in alphabetical order in InitializePasses.h.

Sep 25 2020, 9:06 AM · Restricted Project
masakiarai added reviewers for D88293: [ControlDependentDCE] Add Control Dependent DCE pass: rengolin, sebpop, xbolva00.
Sep 25 2020, 5:28 AM · Restricted Project
masakiarai added a comment to D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results.

Thank you very much for your advice.

Sep 25 2020, 5:01 AM
masakiarai requested review of D88293: [ControlDependentDCE] Add Control Dependent DCE pass.
Sep 25 2020, 4:59 AM · Restricted Project

Sep 22 2020

masakiarai added a comment to D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results.

I'm sorry for the long suspension due to various changes in my working environment(my job description, email address, etc).
I implemented this as a new optimization pass, so I will upload it.
I'm thinking of getting a new Phabricator review number and linking it from this comment section.
Is this a reasonable procedure?

Sep 22 2020, 11:09 PM

Dec 26 2019

masakiarai added a comment to D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results.

I'm sorry to stagnate this for a very long time.
According to the reviewer's comments, I am preparing this as a new optimization pass as 'Control Dependent DCE'.
With enhancements and additional test programs, I will submit a new review request.

Dec 26 2019, 3:09 AM

Dec 9 2019

masakiarai added a comment to D71122: [ModuloSchedule] Fix data types in ModuloScheduleExpander::isLoopCarried.

Thank you very much for your quick review.
I don't have commit access.
Could you commit this patch?

Dec 9 2019, 4:28 AM · Restricted Project

Dec 6 2019

masakiarai created D71122: [ModuloSchedule] Fix data types in ModuloScheduleExpander::isLoopCarried.
Dec 6 2019, 8:30 AM · Restricted Project

Feb 13 2019

masakiarai updated the diff for D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results.

I uploaded my patch with some fixes.

Feb 13 2019, 12:50 AM
masakiarai added inline comments to D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results.
Feb 13 2019, 12:38 AM
masakiarai added a comment to D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results.

Thank you very much for your quick and detailed review.

Feb 13 2019, 12:32 AM

Feb 8 2019

masakiarai created D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results.
Feb 8 2019, 8:02 AM

Jan 10 2019

masakiarai added a comment to D55106: A new software pipliner pass based on non-SSA form.

I think that there is no particular problem in this part itself.

Jan 10 2019, 1:30 AM

Jun 28 2018

masakiarai added a comment to D47943: Sample code for porting MachinePipeliner to AArch64+SVE.

No, at the moment there is nothing.
Since I think there was no objection to the extension of MachinePipeliner, I am currently creating a patch aimed for upstreaming.
Please review it.
Thank you very much.

Jun 28 2018, 4:17 AM

Jun 11 2018

masakiarai added a comment to D47943: Sample code for porting MachinePipeliner to AArch64+SVE.

Thank you for your detailed comment.
Your points make sense to me.

Jun 11 2018, 7:45 PM

Jun 10 2018

masakiarai updated the diff for D47943: Sample code for porting MachinePipeliner to AArch64+SVE.

Remove irrelevant differences and fix the format.

Jun 10 2018, 6:50 PM

Jun 8 2018

masakiarai created D47948: Sample code for porting MachinePipeliner to AArch64+SVE.
Jun 8 2018, 8:59 AM
masakiarai created D47943: Sample code for porting MachinePipeliner to AArch64+SVE.
Jun 8 2018, 6:31 AM