This is an archive of the discontinued LLVM Phabricator instance.

[libomptarget][nfc] Move omptarget-nvptx under common
ClosedPublic

Authored by JonChesterfield on Dec 5 2019, 10:05 AM.

Details

Summary

[libomptarget][nfc] Move omptarget-nvptx under common

Almost all files depend on require omptarget-nvptx, which no longer
contains any obviously architecture dependent code. Moving it under
common unblocks task/loop for amdgcn, and allows moving other code.

At some point there should probably be a widespread symbol renaming to
replace the nvptx string. I'd prefer to get things working first.

Building this (and task.cu, loop.cu) without a cuda library requires
some more refactoring, e.g. wrap threadfence(), use DEVICE macro more
consistently. Patches for that are orthogonal and will be posted shortly.

Diff Detail

Event Timeline

Drop nvptx suffix?

Drop nvptx suffix?

On the filenames, or more extensively?

Filename is an easy patch. Symbols in general is trickier.

Drop nvptx suffix?

On the filenames, or more extensively?

Filename is an easy patch. Symbols in general is trickier.

Filenames

  • Drop nvptx suffix from filenames
This revision is now accepted and ready to land.Dec 5 2019, 11:50 AM
This revision was automatically updated to reflect the committed changes.