Page MenuHomePhabricator

[TypeCategory] IsApplicable doesn't seem to apply.

Authored by davide on Dec 3 2019, 3:23 PM.


Event Timeline

davide created this revision.Dec 3 2019, 3:23 PM
Herald added a project: Restricted Project. ยท View Herald TranscriptDec 3 2019, 3:23 PM
davide added a comment.Dec 3 2019, 3:26 PM

Please don't merge this yet. I'm mostly trying to understand if this is dead code or not.

@jingham , this is one of the places in generic code where we hardcode knowledge about the languages. Needless to say, it causes conflicts downstream and feels wrong anyway.
After some amount of yak shaving I realized this is not quite used. What do you think about it? I thought this might be needed for some sort of filtering on language but I really can't seem to be able to trigger it on a testcase [or reading the code].

This seems like it will make a lot more work happen. Many C++ formatters are regex based and are quite expensive to compare against type names. Seems worthwhile to skip if the language doesn't match?

davide abandoned this revision.Dec 3 2019, 3:43 PM

Nevermind, I found a better way.