Page MenuHomePhabricator

Add ProcName to TimeTraceProfiler
ClosedPublic

Authored by russell.gallop on Dec 3 2019, 3:07 AM.

Details

Summary

This was hard-coded to "clang". This change allows it to to be used on processes other than clang (such as lld).

This gets reported as clang-10 on Linux and clang.exe on Windows so adapted test to accommodate this.

This change is working towards LLD time trace support, RFC here: https://reviews.llvm.org/D69043

Diff Detail

Event Timeline

russell.gallop created this revision.Dec 3 2019, 3:07 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 3 2019, 3:07 AM
anton-afanasyev accepted this revision.Dec 3 2019, 3:22 AM
This revision is now accepted and ready to land.Dec 3 2019, 3:22 AM
This revision was automatically updated to reflect the committed changes.
rnk added a subscriber: rnk.Jan 30 2020, 4:13 PM

This broke ClangBuildAnalyzer on Windows because it has a very naive check for "clang":
https://github.com/aras-p/ClangBuildAnalyzer/blob/master/src/main.cpp#L148
I was wondering why this wasn't working on Windows anymore. =/

In D70950#1850796, @rnk wrote:

This broke ClangBuildAnalyzer on Windows because it has a very naive check for "clang":
https://github.com/aras-p/ClangBuildAnalyzer/blob/master/src/main.cpp#L148
I was wondering why this wasn't working on Windows anymore. =/

I think this should be fixed by this recent change to ClangBuildAnalyzer: https://github.com/aras-p/ClangBuildAnalyzer/commit/7ccac789ba5846c04392755a71856b18b7f0c2c1

That should cope with both clang-11 and clang.exe.