Page MenuHomePhabricator

[llvm-exegesis] Fix 44b9942898c7.
ClosedPublic

Authored by courbet on Mon, Dec 2, 6:32 AM.

Details

Summary

Add missing stack release instructions in
loadImplicitRegAndFinalize.

Diff Detail

Event Timeline

courbet created this revision.Mon, Dec 2, 6:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Dec 2, 6:32 AM
Herald added a subscriber: tschuett. · View Herald Transcript
courbet updated this revision to Diff 231702.Mon, Dec 2, 6:49 AM

And add unit test.

kadircet accepted this revision.Mon, Dec 2, 6:59 AM

LGTM, thanks!

llvm/test/tools/llvm-exegesis/X86/latency-SQRTSSr.s
3

could you add a comment about the test? I believe the context wouldn't be clear to anyone looking at the test or this revision.

This revision is now accepted and ready to land.Mon, Dec 2, 6:59 AM
courbet updated this revision to Diff 231705.Mon, Dec 2, 7:13 AM

More comments.

This revision was automatically updated to reflect the committed changes.

Thanks and sorry for the mistake.