Page MenuHomePhabricator

[update_cc_test_checks.py] Use CHECK_RE from common
ClosedPublic

Authored by arichardson on Dec 2 2019, 3:06 AM.

Details

Summary

This change modifies the common.CHECK_RE regex to also handle '//'
comment prefixes which allows us to share it between clang and IR tests.
Using the regex from common means that *-SAME lines are also stripped
now. Before this change using the --function-signature flag would result
in -SAME: lines from previous runs not being removed.

Event Timeline

arichardson created this revision.Dec 2 2019, 3:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2019, 3:06 AM
jdoerfert accepted this revision.Dec 2 2019, 9:26 AM
jdoerfert added a subscriber: jdoerfert.

LGTM.

I think I have the same downstream patch :)

This revision is now accepted and ready to land.Dec 2 2019, 9:26 AM
This revision was automatically updated to reflect the committed changes.