Page MenuHomePhabricator

[docs] Fixed incorrect build instructions for Scudo
AcceptedPublic

Authored by alex on Fri, Nov 29, 8:32 AM.

Details

Reviewers
eugenis
cryptoad
Summary

The docs previously said to compile *.cc, but the C++ files in that directory all use the .cpp extension.

Event Timeline

alex created this revision.Fri, Nov 29, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Nov 29, 8:32 AM
cryptoad accepted this revision.Fri, Nov 29, 1:07 PM
This revision is now accepted and ready to land.Fri, Nov 29, 1:07 PM
alex added a comment.Fri, Nov 29, 1:12 PM

FYI, I'm not an LLVM committer, so I'll need someone to merge this for me. Thanks!

FYI, I'm not an LLVM committer, so I'll need someone to merge this for me. Thanks!

Ack, I'll get to it shortly.
I have to redo the whole thing since it's not accounting for the new "standalone" version of the allocator.

alex added a comment.Mon, Dec 2, 5:18 PM

FWIW, another thing that probably deserves to be mentioned is that compiling it this way does not get you the GWP-ASAN integration, you need to go via CMake if you want that.