This is an archive of the discontinued LLVM Phabricator instance.

[Attributor] Copy or port test cases related to Attributor to` Attributor` test folder
ClosedPublic

Authored by uenoku on Nov 29 2019, 1:32 AM.

Details

Summary

This patch moves the test cases related to Attributor to Transforms/Attributor folder.
We have used Transforms/FunctionAttrs as the primary folder for Attributor test but we need to change testing way now.

For the test cases which I think functionattrs doesn't infer anything something like (willreturn, nosync, value-simplify, h2s ..etc), I moved them with the command git mv.

For the test cases in which functoinattrs and attributor are tested, I copied the test to the folder and remove the check only used by functoinattrs.

Diff Detail

Event Timeline

uenoku created this revision.Nov 29 2019, 1:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2019, 1:32 AM

Did you also remove the Attributor related check lines etc. from the function attrs tests? I cannot find that in the diff.

Did you also remove the Attributor related check lines etc. from the function attrs tests? I cannot find that in the diff.

I missed it.I'll add later.

uenoku updated this revision to Diff 231606.Nov 30 2019, 7:31 PM

Remove attributor tests in FunctoinAttrs and InferFunctoinAttrs.

jdoerfert accepted this revision.Dec 1 2019, 10:14 AM

Thx. LGTM.

Nit: Could you rename the arg_XXX and fn_XXX into XXX to match the general naming scheme.

This revision is now accepted and ready to land.Dec 1 2019, 10:14 AM
uenoku updated this revision to Diff 231683.Dec 2 2019, 5:36 AM

Address comment

This revision was automatically updated to reflect the committed changes.