[LLDB] Always interpret arm instructions as thumb on windows

[mstorsjo]

Summary

Windows on arm always uses thumb mode, and doesn't have most of the mechanisms that are used in e.g. ELF for distinguishing between arm and thumb.

[labath]

Seems reasonable. Just out of curiosity, is this restriction enforced in some way? E.g., if I manually do a bx to an arm address, will the system kill me?

[mstorsjo]

In D70796#1762491, @labath wrote:

Seems reasonable. Just out of curiosity, is this restriction enforced in some way? E.g., if I manually do a bx to an arm address, will the system kill me?

No, such simple cases do work (or at least they used to), but the linker doesn't really have any means to e.g. set the x bit in bl/blx instructions properly. And allegedly, in earlier versions, the kernel didn't switch modes correctly when entering the kernel, so entering the kernel from arm code, would try to execute the kernel's code in arm mode, effectively crashing the system (https://reviews.llvm.org/D43005#1018582 for reference). I think that aspect is fixed these days, but it's pretty much unsupported on most levels where the interworking requires some support from the tools or frameworks.

[labath]

In D70796#1762526, @mstorsjo wrote:

And allegedly, in earlier versions, the kernel didn't switch modes correctly when entering the kernel, so entering the kernel from arm code, would try to execute the kernel's code in arm mode, effectively crashing the system

LOL :D

[teemperor]

This is failing for me with:

(lldb) disassemble -b -n entry
error: Unable to find Disassembler plug-in for the 'armv7' architecture.

I assume that's because I run with LLVM_TARGETS_TO_BUILD:STRING=X86;AArch64 in my CMake configuration. Do we have a way to make this test condition on the ARM target being enabled or do we have the ARM target as a hard requirement for the test suit?

[labath]

REQUIRES: arm ought to do the trick.

[mstorsjo]

In D70796#1762774, @teemperor wrote:

This is failing for me with:

(lldb) disassemble -b -n entry
error: Unable to find Disassembler plug-in for the 'armv7' architecture.

I assume that's because I run with LLVM_TARGETS_TO_BUILD:STRING=X86;AArch64 in my CMake configuration.

Oops, sorry about that.

Do we have a way to make this test condition on the ARM target being enabled or do we have the ARM target as a hard requirement for the test suit?

The ARM target should definitely not be a hard requirement. Is the test skipped for you if you add a # REQUIRES: arm line?

[mstorsjo]

I pushed a commit to add such a REQUIRES line now.

[teemperor]

Yeah, that fixes it. Thanks!

lldb/source/Utility/ArchSpec.cpp

if (GetTriple().getArch() == llvm::Triple::arm ||
     if (GetCore() == ArchSpec::Core::eCore_arm_armv7m ||
         GetCore() == ArchSpec::Core::eCore_arm_armv7em ||
         GetCore() == ArchSpec::Core::eCore_arm_armv6m ||
         GetCore() == ArchSpec::Core::eCore_thumbv7m ||
         GetCore() == ArchSpec::Core::eCore_thumbv7em ||
         GetCore() == ArchSpec::Core::eCore_thumbv6m) {
       return true;
     }
+    // Windows on ARM is always thumb.
+    if (GetTriple().isOSWindows())
+      return true;
   }
   return false;
 }
 
 void ArchSpec::DumpTriple(Stream &s) const {
   const llvm::Triple &triple = GetTriple();
   llvm::StringRef arch_str = triple.getArchName();
   llvm::StringRef vendor_str = triple.getVendorName();

lldb/test/Shell/ObjectFile/PECOFF/disassemble-thumb.yaml

+# RUN: yaml2obj %s > %t.exe
+# RUN: %lldb %t.exe -o "disassemble -b -n entry" -b | FileCheck %s
+
+# CHECK: {{.*}}.exe[0x401000] <+0>: 0x0040 lsls   r0, r0, #0x1
+# CHECK: {{.*}}.exe[0x401002] <+2>: 0x4770 bx     lr
+
+--- !COFF
+OptionalHeader:
+  AddressOfEntryPoint: 4097
+  ImageBase:       4194304
+  SectionAlignment: 4096
+  FileAlignment:   512
+  MajorOperatingSystemVersion: 6
+  MinorOperatingSystemVersion: 0
+  MajorImageVersion: 0
+  MinorImageVersion: 0
+  MajorSubsystemVersion: 6
+  MinorSubsystemVersion: 0
+  Subsystem:       IMAGE_SUBSYSTEM_WINDOWS_CUI
+  DLLCharacteristics: [ IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE, IMAGE_DLL_CHARACTERISTICS_NX_COMPAT, IMAGE_DLL_CHARACTERISTICS_TERMINAL_SERVER_AWARE ]
+  SizeOfStackReserve: 1048576
+  SizeOfStackCommit: 4096
+  SizeOfHeapReserve: 1048576
+  SizeOfHeapCommit: 4096
+  ExportTable:
+    RelativeVirtualAddress: 0
+    Size:            0
+  ImportTable:
+    RelativeVirtualAddress: 0
+    Size:            0
+  ResourceTable:
+    RelativeVirtualAddress: 0
+    Size:            0
+  ExceptionTable:
+    RelativeVirtualAddress: 0
+    Size:            0
+  CertificateTable:
+    RelativeVirtualAddress: 0
+    Size:            0
+  BaseRelocationTable:
+    RelativeVirtualAddress: 0
+    Size:            0
+  Debug:
+    RelativeVirtualAddress: 0
+    Size:            0
+  Architecture:
+    RelativeVirtualAddress: 0
+    Size:            0
+  GlobalPtr:
+    RelativeVirtualAddress: 0
+    Size:            0
+  TlsTable:
+    RelativeVirtualAddress: 0
+    Size:            0
+  LoadConfigTable:
+    RelativeVirtualAddress: 0
+    Size:            0
+  BoundImport:
+    RelativeVirtualAddress: 0
+    Size:            0
+  IAT:
+    RelativeVirtualAddress: 0
+    Size:            0
+  DelayImportDescriptor:
+    RelativeVirtualAddress: 0
+    Size:            0
+  ClrRuntimeHeader:
+    RelativeVirtualAddress: 0
+    Size:            0
+header:
+  Machine:         IMAGE_FILE_MACHINE_ARMNT
+  Characteristics: [ IMAGE_FILE_EXECUTABLE_IMAGE, IMAGE_FILE_32BIT_MACHINE ]
+sections:
+  - Name:            .text
+    Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
+    VirtualAddress:  4096
+    VirtualSize:     4
+    SectionData:     '40007047'
+symbols:
+  - Name:            .text
+    Value:           0
+    SectionNumber:   1
+    SimpleType:      IMAGE_SYM_TYPE_NULL
+    ComplexType:     IMAGE_SYM_DTYPE_NULL
+    StorageClass:    IMAGE_SYM_CLASS_STATIC
+  - Name:            entry
+    Value:           0
+    SectionNumber:   1
+    SimpleType:      IMAGE_SYM_TYPE_NULL
+    ComplexType:     IMAGE_SYM_DTYPE_FUNCTION
+    StorageClass:    IMAGE_SYM_CLASS_EXTERNAL
+...