[clangd] Fix typo in symbol kind conversion

[merge_guards_bot]

Build result: pass - 60134 tests passed, 0 failed and 729 were skipped.
Log files: console-log.txt, CMakeCache.txt

clang-tools-extra/clangd/Protocol.cpp

SymbolKind indexSymbolKindToSymbolKind(index::SymbolKind Kind) {
   case index::SymbolKind::StaticMethod:
     return SymbolKind::Method;
   case index::SymbolKind::InstanceProperty:
   case index::SymbolKind::ClassProperty:
   case index::SymbolKind::StaticProperty:
     return SymbolKind::Property;
   case index::SymbolKind::Constructor:
   case index::SymbolKind::Destructor:
-    return SymbolKind::Method;
+    return SymbolKind::Constructor;
   case index::SymbolKind::ConversionFunction:
     return SymbolKind::Function;
   case index::SymbolKind::Parameter:
     return SymbolKind::Variable;
   case index::SymbolKind::Using:
     return SymbolKind::Namespace;
   }
   llvm_unreachable("invalid symbol kind");

clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp

Annotations Main(R"(
     )");
 
   addFile(FilePath, Main.code());
   EXPECT_THAT(
       getSymbols(FilePath),
       ElementsAreArray(
           {AllOf(WithName("Foo"), WithKind(SymbolKind::Class), Children()),
            AllOf(WithName("Foo"), WithKind(SymbolKind::Class),
-                 Children(AllOf(WithName("Foo"), WithKind(SymbolKind::Method),
-                                Children()),
-                          AllOf(WithName("Foo"), WithKind(SymbolKind::Method),
-                                Children()),
+                 Children(AllOf(WithName("Foo"),
+                                WithKind(SymbolKind::Constructor), Children()),
+                          AllOf(WithName("Foo"),
+                                WithKind(SymbolKind::Constructor), Children()),
                           AllOf(WithName("f"), WithKind(SymbolKind::Method),
                                 Children()),
                           AllOf(WithName("operator="),
                                 WithKind(SymbolKind::Method), Children()),
-                          AllOf(WithName("~Foo"), WithKind(SymbolKind::Method),
-                                Children()),
+                          AllOf(WithName("~Foo"),
+                                WithKind(SymbolKind::Constructor), Children()),
                           AllOf(WithName("Nested"), WithKind(SymbolKind::Class),
                                 Children(AllOf(WithName("f"),
                                                WithKind(SymbolKind::Method),
                                                Children()))))),
            AllOf(WithName("Friend"), WithKind(SymbolKind::Class), Children()),
            AllOf(WithName("f1"), WithKind(SymbolKind::Function), Children()),
            AllOf(WithName("f2"), WithKind(SymbolKind::Function), Children()),
            AllOf(WithName("KInt"), WithKind(SymbolKind::Variable), Children()),

clang-tools-extra/clangd/unittests/XRefsTests.cpp

void foo())cpp";
       {R"cpp(
           template<typename> struct X;
           template<typename T> struct X<T*>{ [[^X]](); };
           )cpp",
        [](HoverInfo &HI) {
          HI.NamespaceScope = "";
          HI.Name = "X";
          HI.LocalScope = "X::";        // FIXME: Should be X<T *>::
-         HI.Kind = SymbolKind::Method; // FIXME: Should be Constructor
+         HI.Kind = SymbolKind::Constructor;
          HI.Type = "void ()";          // FIXME: Should be None
          HI.ReturnType = "void";       // FIXME: Should be None or X<T*>
          HI.Definition = "X<type - parameter - 0 - 0 *>()"; // FIXME: --> X()
          HI.Parameters.emplace();
        }},
 
       // auto on lambda
       {R"cpp(