Page MenuHomePhabricator

[z86][SLH] Move isDataInvariant* functions
Changes PlannedPublic

Authored by zbrid on Thu, Nov 14, 2:16 PM.

Details

Reviewers
craig.topper
rnk
Summary

I moved these functions to X86InstrInfo.cpp so I can use them in another
pass I'm working on. Thanks for the suggestion, Craig!

Tested via llvm-lit llvm/test/CodeGen/X86/speculative-load-hardening*

As noted in the FIXMEs that I moved along with the fuctions, these
should eventually be moved to the tablegen instruction tables. There
didn't seem a straightforward way to do that due to the difficulties
trying to handle the check for when EFLAGS is dead for target
independent opcodes.

Event Timeline

zbrid created this revision.Thu, Nov 14, 2:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Nov 14, 2:16 PM
zbrid updated this revision to Diff 229408.Thu, Nov 14, 2:26 PM

Update commit message to explain SLH specific behavior req'd

zbrid planned changes to this revision.Thu, Nov 14, 2:35 PM

I'm going to update this to separate the check for dead EFLAGS from the isDataInvariant function.