Fix up lit's tests to run in a multi-config environment

[jdenny]

What do you think of placing that empty lit.cfg directly within Inputs instead? I think this would generally isolate all Inputs/* test suites from lit/tests/lit.site.cfg and thus avoid such confusion for future tests.

Of course, we might not create any new tests for nonexistent directories, but we might do something else. For example, if we were to forget to create a lit.cfg in some new Inputs subdirectory and it inadvertently came to depend on some configuration item from lit/tests/lit.site.cfg as a result, the new tests might pass locally but then fail under Windows in the manner we just saw. However, if it couldn't pick up lit/tests/lit.site.cfg, then hopefully we'd notice the missing configuration item on any platform.

[probinson]

Move the empty lit.cfg to Inputs; undo selecting.py change.

[probinson]

Done. Makes sense to avoid future mishaps.

[jdenny]

LGTM. Thanks!

[yln]

Thank you Joel and Paul!

llvm/utils/lit/tests/Inputs/selecting/lit.cfg

+# A deliberately empty lit.cfg, so that the test for a nonexistent directory
+# doesn't inadvertently try to load lit/tests/lit.site.cfg (which will fail
+# in a multi-config environment such as Visual Studio or Xcode).

llvm/utils/lit/tests/selecting.py

 # RUN: %{lit} %{inputs}/discovery | FileCheck --check-prefix=CHECK-BASIC %s
 # CHECK-BASIC: Testing: 5 tests
 
 
 # Check that we exit with an error if we do not discover any tests, even with --allow-empty-runs.
 #
-# RUN: not %{lit} %{inputs}/nonexistent                    2>&1 | FileCheck --check-prefix=CHECK-BAD-PATH %s
-# RUN: not %{lit} %{inputs}/nonexistent --allow-empty-runs 2>&1 | FileCheck --check-prefix=CHECK-BAD-PATH %s
+# RUN: not %{lit} %{inputs}/selecting/nonexistent                    2>&1 | FileCheck --check-prefix=CHECK-BAD-PATH %s
+# RUN: not %{lit} %{inputs}/selecting/nonexistent --allow-empty-runs 2>&1 | FileCheck --check-prefix=CHECK-BAD-PATH %s
 # CHECK-BAD-PATH: Did not disover any tests for provided path(s).
 
 # Check that we exit with an error if we filter out all tests, but allow it with --allow-empty-runs.
 #
 # RUN: not %{lit} --filter 'nonexistent'                    %{inputs}/discovery 2>&1 | FileCheck --check-prefixes=CHECK-BAD-FILTER,CHECK-BAD-FILTER-ERROR %s
 # RUN:     %{lit} --filter 'nonexistent' --allow-empty-runs %{inputs}/discovery 2>&1 | FileCheck --check-prefixes=CHECK-BAD-FILTER,CHECK-BAD-FILTER-ALLOW %s
 # CHECK-BAD-FILTER: Filter did not match any tests (of 5 discovered).
 # CHECK-BAD-FILTER-ERROR: Use '--allow-empty-runs' to suppress this error.