Page MenuHomePhabricator

Fix up lit's tests to run in a multi-config environment
ClosedPublic

Authored by probinson on Nov 14 2019, 6:03 AM.

Diff Detail

Event Timeline

probinson created this revision.Nov 14 2019, 6:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 14 2019, 6:03 AM

What do you think of placing that empty lit.cfg directly within Inputs instead? I think this would generally isolate all Inputs/* test suites from lit/tests/lit.site.cfg and thus avoid such confusion for future tests.

Of course, we might not create any new tests for nonexistent directories, but we might do something else. For example, if we were to forget to create a lit.cfg in some new Inputs subdirectory and it inadvertently came to depend on some configuration item from lit/tests/lit.site.cfg as a result, the new tests might pass locally but then fail under Windows in the manner we just saw. However, if it couldn't pick up lit/tests/lit.site.cfg, then hopefully we'd notice the missing configuration item on any platform.

probinson updated this revision to Diff 229322.Nov 14 2019, 8:58 AM

Move the empty lit.cfg to Inputs; undo selecting.py change.

Done. Makes sense to avoid future mishaps.

jdenny accepted this revision.Nov 14 2019, 9:33 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 14 2019, 9:33 AM
yln added a comment.Nov 14 2019, 11:07 AM

Thank you Joel and Paul!

This revision was automatically updated to reflect the committed changes.