This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readelf/llvm-readobj][test] - Convert elf-linker-options.ll to use YAML.
ClosedPublic

Authored by grimar on Nov 8 2019, 4:29 AM.

Details

Summary

This converts elf-linker-options.ll to use yaml2obj instead of llc,
improves and cleanups it slightly.

This opens a road to add an additional tests for checking the broken cases.

Diff Detail

Event Timeline

grimar created this revision.Nov 8 2019, 4:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2019, 4:29 AM
grimar updated this revision to Diff 228413.Nov 8 2019, 4:33 AM
  • Rename to '*.test`.
jhenderson accepted this revision.Nov 8 2019, 5:44 AM

LGTM, aside from one comment.

llvm/test/tools/llvm-readobj/elf-linker-options.test
2

"use the --elf-linker-options option" or simply "use --elf-linker-options"

This revision is now accepted and ready to land.Nov 8 2019, 5:44 AM
MaskRay accepted this revision.Nov 8 2019, 10:34 AM

Probably add [test] in the title.

grimar retitled this revision from [llvm-readelf/llvm-readobj] - Convert elf-linker-options.ll to use YAML. to [llvm-readelf/llvm-readobj][test] - Convert elf-linker-options.ll to use YAML..Nov 11 2019, 11:08 PM
This revision was automatically updated to reflect the committed changes.