Page MenuHomePhabricator

[TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (3) (baseline tests)
ClosedPublic

Authored by joanlluch on Nov 7 2019, 3:32 PM.

Details

Summary

This is baseline tests for D69326

Incorporates a command line flag for the MSP430 and adds a test cases to help showing the effects of applying D69326

More details and motivation for this patch in D69326

Diff Detail

Event Timeline

joanlluch created this revision.Nov 7 2019, 3:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 7 2019, 3:32 PM
joanlluch set the repository for this revision to rG LLVM Github Monorepo.
joanlluch updated this revision to Diff 228330.Nov 7 2019, 3:39 PM
spatel accepted this revision.Nov 7 2019, 3:48 PM

LGTM

This revision is now accepted and ready to land.Nov 7 2019, 3:48 PM
asl accepted this revision.Nov 7 2019, 11:24 PM
joanlluch added a comment.EditedNov 8 2019, 2:03 AM

Hi @spatel, @asl
Thanks for reviewing this. I'm getting some trouble at committing to the upstream repo in the way I would like. I asked for help here first, but then I thought it was better to use llvm-dev instead to avoid clutter here. So this is an edit removing my previous comment. Thanks again

spatel added a comment.Nov 8 2019, 6:28 AM

Hi @spatel, @asl
Thanks for reviewing this. I'm getting some trouble at committing to the upstream repo in the way I would like. I asked for help here first, but then I thought it was better to use llvm-dev instead to avoid clutter here. So this is an edit removing my previous comment. Thanks again

Posting the question to llvm-dev was the correct choice. It may be off-topic for this patch, but let me link it here for reference since the original comment went to the lists/email from here:
http://lists.llvm.org/pipermail/llvm-dev/2019-November/136610.html
(I don't know the answer myself, so hopefully someone else can tell us.)

This revision was automatically updated to reflect the committed changes.