This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Enable thin lto cache when building with lld-link
ClosedPublic

Authored by russell.gallop on Nov 7 2019, 3:58 AM.

Details

Summary

This was enabled for other platforms. Added option for Windows/lld-link.

Diff Detail

Event Timeline

russell.gallop created this revision.Nov 7 2019, 3:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 7 2019, 3:58 AM
rnk accepted this revision.Nov 7 2019, 10:14 AM

@inglorion ended up disabling the thinlto cache on Windows. I've been assuming it is buggy on Windows, i.e. it relies on filesystem invariants not provided there. But, if it works for you, I'm happy to try it. We continuously build some tools such as LLD in this configuration in Chromium, so I think we'll just pick this up and see if it works out of the box.

lgtm

This revision is now accepted and ready to land.Nov 7 2019, 10:14 AM

Thanks.

Maybe this is what you're referring to: https://bugs.llvm.org/show_bug.cgi?id=38616

It seems to work for me, though I may not have done as much testing as @inglorion.

We document this option (https://clang.llvm.org/docs/ThinLTO.html#incremental) so I'd like to try enabling it.

This revision was automatically updated to reflect the committed changes.