This is an archive of the discontinued LLVM Phabricator instance.

[codeview] Reference types in type parent scopes
ClosedPublic

Authored by rnk on Nov 6 2019, 3:08 PM.

Details

Summary

Without this change, when a nested tag type of any kind (enum, class,
struct, union) is used as a variable type, it is emitted without
emitting the parent type. In CodeView, parent types point to their inner
types, and inner types do not point back to their parents. We already
walk over all of the parent scopes to build the fully qualified name.
This change simply requests their type indices as we go along to enusre
they are all emitted.

Fixes PR43905

Event Timeline

rnk created this revision.Nov 6 2019, 3:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2019, 3:09 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
akhuang accepted this revision.Nov 7 2019, 1:38 PM

lgtm thanks!

This revision is now accepted and ready to land.Nov 7 2019, 1:38 PM
This revision was automatically updated to reflect the committed changes.