Page MenuHomePhabricator

[Hurd]: use /proc/self/exe to get program path

Authored by sthibaul on Oct 31 2019, 2:00 PM.

Diff Detail

Event Timeline

sthibaul created this revision.Oct 31 2019, 2:00 PM

Is there a better way to check for a Hurd host than using the __GNU__ preprocessor macro? I'm worried it may cause some confusion otherwise similar to the issue with Hurd triples. It seems that Hurd target defines __gnu_hurd__, which is a lot less ambiguous and probably self-explanatory than __GNU__ (especially considering how often __GNUC__ is defined and given that it has a completely different meaning). Aside from that, LGTM!

gnu_hurd can work as well indeed

kristina accepted this revision.Nov 1 2019, 9:59 AM

gnu_hurd can work as well indeed

LGTM! Let me know if you need this committed.

This revision is now accepted and ready to land.Nov 1 2019, 9:59 AM
sthibaul updated this revision to Diff 227475.Nov 1 2019, 10:15 AM

Here it is updated to use gnu_hurd, please commit indeed

This revision was automatically updated to reflect the committed changes.