_setmode in assert will not run when build with NDEBUG
I presume you applied the patch with arc patch? It seems to apply the Phabricator username as git user, which is a bit odd, as it is customary to use realnames in the git author field. Earlier, when everything ended up mangled by svn, everything ended up normalized to the committer's name anyway, but as git preserves the author names, it would probably be good if the arc workflow could use the realname instead.
Yes, I used "arc patch". I did check that it preserved the authorship information, but I did not go into the details of what's in the author field TBH. I agree it would be better to have the full name there, but I don't know if there's a way to change that (short of people doing "git commit --amend --author=XXX" manually, which everyone is going to forget).