This is an archive of the discontinued LLVM Phabricator instance.

[LLDB][formatters] ArgInfo::count -> ArgInfo::max_positional_args
ClosedPublic

Authored by lawrence_danna on Oct 26 2019, 6:07 PM.

Details

Summary

Move breakpoints from the old, bad ArgInfo::count to the new, better
ArgInfo::max_positional_args. Soon ArgInfo::count will be no more.

This functionality is tested in TestFormatters.py, TestDataFormatterSynthVal.py,
TestDataFormatterSynthType.py.

You may notice that the old code was passing 0 arguments when count was 1, and passing
1 argument when count is 2.

This is no longer necessary because max_positional_args counts the self pointer
correctly.

Event Timeline

lawrence_danna created this revision.Oct 26 2019, 6:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2019, 6:07 PM
labath accepted this revision.Oct 27 2019, 8:10 AM
This revision is now accepted and ready to land.Oct 27 2019, 8:10 AM
This revision was automatically updated to reflect the committed changes.