Page MenuHomePhabricator

[xray] Remove cl::sub from alias options
ClosedPublic

Authored by rmansfield on Oct 24 2019, 7:40 AM.

Details

Summary

Currently running the xray tools generates a number of errors:

$ ./bin/llvm-xray
: for the -k option: cl::alias must not have cl::sub(), aliased option's cl::sub() will be used!
: for the -d option: cl::alias must not have cl::sub(), aliased option's cl::sub() will be used!
: for the -o option: cl::alias must not have cl::sub(), aliased option's cl::sub() will be used!
: for the -f option: cl::alias must not have cl::sub(), aliased option's cl::sub() will be used!
: for the -s option: cl::alias must not have cl::sub(), aliased option's cl::sub() will be used!
: for the -r option: cl::alias must not have cl::sub(), aliased option's cl::sub() will be used!
: for the -p option: cl::alias must not have cl::sub(), aliased option's cl::sub() will be used!
: for the -m option: cl::alias must not have cl::sub(), aliased option's cl::sub() will be used!
<snip>

Diff Detail

Event Timeline

rmansfield created this revision.Oct 24 2019, 7:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2019, 7:40 AM
dberris accepted this revision.Oct 27 2019, 3:03 PM

LGTM -- Thanks!

This revision is now accepted and ready to land.Oct 27 2019, 3:03 PM

Thanks for the review. I don't have commit access, is someone able to commit the change?

Is someone able to commit this change on my behalf?

@smeenai or @hiraditya we could use this too, maybe one of you can merge?

Sorry for the delay. Committed this.

This revision was automatically updated to reflect the committed changes.