Page MenuHomePhabricator

rmansfield (Ryan Mansfield)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 7 2016, 9:37 AM (282 w, 3 d)

Recent Activity

Tue, Nov 30

rmansfield added a comment to D114710: Fix file extension of alignment-assumption-ignorelist.cppp test.

Thanks. Could someone please commit on my behalf? I don't have commit access.

Tue, Nov 30, 6:05 AM · Restricted Project

Mon, Nov 29

rmansfield added reviewers for D114710: Fix file extension of alignment-assumption-ignorelist.cppp test: hans, thakis.
Mon, Nov 29, 7:46 AM · Restricted Project
rmansfield requested review of D114710: Fix file extension of alignment-assumption-ignorelist.cppp test.
Mon, Nov 29, 7:44 AM · Restricted Project

Sep 28 2021

rmansfield added a comment to D110634: [llvm] Update IR verifier to reject non-power-of-2 alignment assume bundles (PR48713)..

I think this looks good, need to update some tests though.

Sep 28 2021, 10:06 AM · Restricted Project
rmansfield requested review of D110634: [llvm] Update IR verifier to reject non-power-of-2 alignment assume bundles (PR48713)..
Sep 28 2021, 8:50 AM · Restricted Project
rmansfield updated the diff for D94433: Do not emit non-power-of-2 alignment assume bundles (PR48713)..

Separate clang and llvm changes. I'm still looking for clarification on what clang should be emitting in the non-power of case.

Sep 28 2021, 8:48 AM · Restricted Project

Sep 9 2021

rmansfield added inline comments to D94433: Do not emit non-power-of-2 alignment assume bundles (PR48713)..
Sep 9 2021, 11:39 AM · Restricted Project
rmansfield added a comment to D109508: [lldb] Fix format string in Communication::Write.

Thanks. Could someone please apply on my behalf?

Sep 9 2021, 7:47 AM · Restricted Project
rmansfield requested review of D109508: [lldb] Fix format string in Communication::Write.
Sep 9 2021, 7:15 AM · Restricted Project

Aug 13 2021

rmansfield abandoned D106889: [examples] Fix the clang-interpreter example for changes in 2487db1f2862.

This got fixed by b4c0307d598004cfd96c770d2a4a84a37c838ba9

Aug 13 2021, 8:07 AM · Restricted Project

Aug 6 2021

rmansfield added inline comments to D94433: Do not emit non-power-of-2 alignment assume bundles (PR48713)..
Aug 6 2021, 12:18 PM · Restricted Project
rmansfield updated the diff for D94433: Do not emit non-power-of-2 alignment assume bundles (PR48713)..
Aug 6 2021, 9:43 AM · Restricted Project

Aug 3 2021

rmansfield added a comment to D106368: [AlignmentFromAssumptions] avoid crash on alignment constant expression.

I still believe we should not create alignment annotations for non-power-of-two constants. This is the second time in a few weeks this causes problems and we still play whack-a-mole instead of restricting clang and teaching the verifier.

https://reviews.llvm.org/D94433

Ah, I didn't realize this is the same problem based on the reduced test. Someone familiar with this feature in Clang -- and compatibility with GCC? -- should have a look then ( @lebedev.ri @erichkeane ? ) - I have no idea what this is supposed to do.

We (clang) already diagnoses it, but doesn't refuse to codegen it.
I think it should just hard-error on it, without emitting IR.

Aug 3 2021, 8:45 AM · Restricted Project

Jul 27 2021

rmansfield requested review of D106889: [examples] Fix the clang-interpreter example for changes in 2487db1f2862.
Jul 27 2021, 9:30 AM · Restricted Project

Jan 11 2021

rmansfield updated the diff for D94433: Do not emit non-power-of-2 alignment assume bundles (PR48713)..

Updated diff with context

Jan 11 2021, 11:24 AM · Restricted Project
rmansfield updated the diff for D94433: Do not emit non-power-of-2 alignment assume bundles (PR48713)..
Jan 11 2021, 11:13 AM · Restricted Project
rmansfield updated the diff for D94433: Do not emit non-power-of-2 alignment assume bundles (PR48713)..
Jan 11 2021, 11:10 AM · Restricted Project
rmansfield requested review of D94433: Do not emit non-power-of-2 alignment assume bundles (PR48713)..
Jan 11 2021, 10:36 AM · Restricted Project

May 14 2020

rmansfield added a comment to D79953: [lldb] Update stop info override callback comment..

Yes, if you can commit it I'd appreciate it.

May 14 2020, 1:03 PM · Restricted Project
rmansfield created D79953: [lldb] Update stop info override callback comment..
May 14 2020, 11:57 AM · Restricted Project

May 2 2020

rmansfield added a comment to D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer.

They're overly reduced examples ;) but embedded programmers tend to make heavy use of shift operators, including within for loops and if stmts

May 2 2020, 4:26 PM · Restricted Project, Restricted Project
rmansfield added a comment to D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer.

Couple examples:

May 2 2020, 1:14 PM · Restricted Project, Restricted Project

Dec 2 2019

rmansfield added a comment to D69386: [xray] Remove cl::sub from alias options.

Is someone able to commit this change on my behalf?

Dec 2 2019, 10:25 AM · Restricted Project

Oct 28 2019

rmansfield added a comment to D69386: [xray] Remove cl::sub from alias options.

Thanks for the review. I don't have commit access, is someone able to commit the change?

Oct 28 2019, 6:37 AM · Restricted Project

Oct 24 2019

rmansfield created D69386: [xray] Remove cl::sub from alias options.
Oct 24 2019, 7:48 AM · Restricted Project