This is an archive of the discontinued LLVM Phabricator instance.

[IRMover] Set Address Space for moved global values
ClosedPublic

Authored by ekatz on Oct 23 2019, 4:10 PM.

Details

Summary

Set Address Space when creating a new function (from another).

Fix PR41154.

Diff Detail

Event Timeline

ekatz created this revision.Oct 23 2019, 4:10 PM

This seems fine to me, but can you pull out and commit the NFC parts first, and update the patch to just contain the functional change? It's harder to see with all the NFC changes in here. The NFC part can go in without a phabricator patch.

llvm/test/Linker/addrspace.ll
1

suggest adding an alias in here for completeness

ekatz updated this revision to Diff 226845.Oct 29 2019, 12:12 AM
ekatz edited the summary of this revision. (Show Details)

Added alias testing, and moved the NFC part into https://reviews.llvm.org/D69550.

This revision is now accepted and ready to land.Oct 29 2019, 6:55 AM
ekatz added a comment.Oct 29 2019, 8:11 AM

I cannot commit this patch myself.
Please commit it, if you may, in my behalf.

Author: Ehud Katz <ehudkatz@gmail.com>

Thanks.

This revision was automatically updated to reflect the committed changes.