This is an archive of the discontinued LLVM Phabricator instance.

[Alignment][NFC] Convert AllocaInst to MaybeAlign
ClosedPublic

Authored by gchatelet on Oct 22 2019, 4:47 AM.

Details

Summary

This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Event Timeline

gchatelet created this revision.Oct 22 2019, 4:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2019, 4:47 AM
courbet added inline comments.Oct 22 2019, 5:10 AM
llvm/lib/Transforms/Scalar/SROA.cpp
4154–4155

why not getValueOrABITypeALignment() ?

gchatelet updated this revision to Diff 226036.Oct 22 2019, 5:43 AM
  • Address comments
gchatelet marked an inline comment as done.Oct 22 2019, 5:59 AM
courbet accepted this revision.Oct 23 2019, 2:24 AM
courbet added inline comments.
llvm/lib/Transforms/Scalar/SROA.cpp
4157

merge + const ?

This revision is now accepted and ready to land.Oct 23 2019, 2:24 AM
gchatelet updated this revision to Diff 226127.Oct 23 2019, 5:52 AM
  • Address comments
This revision was automatically updated to reflect the committed changes.