Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | ||
---|---|---|
1832 | I’m debating if this should really go in the combiner, but this is fine for now | |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
7550 ↗ | (On Diff #225813) | Unrelated change |
llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fast-unsafe-fdiv.mir | ||
3 | I don’t think this needs -global-isel-abort | |
47 | This test isn’t doing much with the global flag enabled |
llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fast-unsafe-fdiv.mir | ||
---|---|---|
3 | The legalization for base types will come in next series of patches. I could just remove it then. |
Comment Actions
LGTM with minor fix
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | ||
---|---|---|
1830 | This should return false as it's unhandled |
This should return false as it's unhandled