Page MenuHomePhabricator

AMDGPU/GlobalISel: Legalize fast unsafe FDIV
ClosedPublic

Authored by kerbowa on Oct 20 2019, 7:00 PM.

Diff Detail

Event Timeline

kerbowa created this revision.Oct 20 2019, 7:00 PM
arsenm added inline comments.Oct 21 2019, 8:51 AM
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
1832

I’m debating if this should really go in the combiner, but this is fine for now

llvm/lib/Target/AMDGPU/SIISelLowering.cpp
7550 ↗(On Diff #225813)

Unrelated change

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fast-unsafe-fdiv.mir
3

I don’t think this needs -global-isel-abort

47

This test isn’t doing much with the global flag enabled

kerbowa marked an inline comment as done.Oct 21 2019, 9:46 AM
kerbowa added inline comments.
llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fast-unsafe-fdiv.mir
3

The legalization for base types will come in next series of patches. I could just remove it then.

kerbowa updated this revision to Diff 225906.Oct 21 2019, 9:48 AM

Add runline with unsafe math disabled. Remove unrelated change.

arsenm added inline comments.Oct 21 2019, 10:27 AM
llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fast-unsafe-fdiv.mir
3

Also need a runline for SI/CI to test the f16 promotion

245

Missing vector tests for the scalarize action

kerbowa updated this revision to Diff 225927.Oct 21 2019, 11:20 AM

Add SI runline and vector tests.

arsenm accepted this revision.Oct 21 2019, 12:03 PM

LGTM with minor fix

llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
1830

This should return false as it's unhandled

This revision is now accepted and ready to land.Oct 21 2019, 12:03 PM
This revision was automatically updated to reflect the committed changes.