Page MenuHomePhabricator

[Arm][libsanitizer] Fix arm libsanitizer failure with bleeding edge glibc
ClosedPublic

Authored by tnfchris on Thu, Oct 17, 5:07 AM.

Details

Summary

Glibc has recently introduced changed to the mode field in ipc_perm in commit 2f959dfe849e0646e27403f2e4091536496ac0f0. For Arm this means that the mode field no longer has the same size.

This causes an assert failure against libsanitizer's internal copy of ipc_perm. Since this change can't be easily detected I am adding arm to the list of targets that are excluded from this check.

Diff Detail

Event Timeline

tnfchris created this revision.Thu, Oct 17, 5:07 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptThu, Oct 17, 5:07 AM
Herald added subscribers: llvm-commits, Restricted Project, kristof.beyls. · View Herald Transcript

Please update the patch with more context, i.e., run git diff -U99999 or something similar. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

tnfchris updated this revision to Diff 225412.Thu, Oct 17, 5:44 AM

Add more context, to diff.

eugenis accepted this revision.Thu, Oct 17, 4:33 PM
eugenis added a subscriber: eugenis.

LGTM
We only really care about the size of struct shmid_ds AFAIK, not any of its fields individually.

This revision is now accepted and ready to land.Thu, Oct 17, 4:33 PM
This revision was automatically updated to reflect the committed changes.