This is an archive of the discontinued LLVM Phabricator instance.

[LNT] Python 3 support: read machine deletion page as text
AbandonedPublic

Authored by thopre on Oct 12 2019, 3:48 PM.

Details

Summary

Test server/ui/test_api_modify.py deletes some machines via the REST
interface and tests that the content of page displayed upon that action.
Since that content is made of text, it is compared against a string.
However by default Flask returns the content as binary data which leads
to an invalid comparison of str against byte. This commit fixes it by
requesting the content as a string from Flask using the as_text
parameter from get_data() property getter.