previously we would generate literal check lines w/o no reg-exps for
vregs as MI flags (nsw, ninf, etc.) won't be recognized as a part of MI.
Fixing that. Includes updating the MIR tests that suffered from the
problem.
Paths
| Differential D68905
[update_mir_test_checks] Handle MI flags properly ClosedPublic Authored by rtereshin on Oct 11 2019, 11:06 PM.
Details Summary previously we would generate literal check lines w/o no reg-exps for Fixing that. Includes updating the MIR tests that suffered from the
Diff Detail
Event TimelineHerald added subscribers: llvm-commits, Petar.Avramovic, atanasyan and 4 others. · View Herald Transcript Comment Actions LGTM
This revision is now accepted and ready to land.Oct 14 2019, 10:14 AM rtereshin added inline comments.
Closed by commit rG044297ccbfcf: [update_mir_test_checks] Handle MI flags properly (authored by rtereshin). · Explain WhyOct 14 2019, 3:02 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 224729 test/CodeGen/AArch64/GlobalISel/legalize-dyn-alloca.mir
test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-br.mir
test/CodeGen/AArch64/GlobalISel/regbank-fma.mir
test/CodeGen/AArch64/GlobalISel/select-jump-table-brjt.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-fadd.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-fcmp.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-fcopysign.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-fcos.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-fmaxnum.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-fminnum.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-fmul.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-fpext.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-fsin.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-fsub.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-intrinsic-amdgcn-fdiv-fast.mir
test/CodeGen/Mips/GlobalISel/legalizer/dyn_stackalloc.mir
utils/update_mir_test_checks.py
|
It'd be kind of nice if we could ensure this list stays up to date somehow, but I suppose it really doesn't change much and we'll notice the first time someone updates a test with a flag that's missing here.